Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Merge pull request #26222 from vipulnsward/26134-fix | Rafael França | 2016-11-13 | 2 | -1/+13 | |
|\ \ | | | | | | | Format and send logs to logger.fatal from DebugExceptions | |||||
| * | | Format and send logs to logger.fatal from DebugExceptions instead of calling ↵ | Vipul A M | 2016-11-12 | 2 | -1/+13 | |
| | | | | | | | | | | | | | | | | | | fatal multiple times. Expose tags_text from TaggedLogging to be used for log formatting Fixes #26134 | |||||
* | | | Merge pull request #27024 from vipulnsward/changelog-edits | Andrew White | 2016-11-13 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Changelog edits | |||||
| * | | | Changelog edits | Vipul A M | 2016-11-12 | 1 | -1/+1 | |
| |/ / | ||||||
* | | | Merge pull request #26905 from bogdanvlviv/docs | Andrew White | 2016-11-13 | 7 | -11/+11 | |
|\ \ \ | | | | | | | | | Add missing `+` around a some literals. | |||||
| * | | | Add missing `+` around a some literals. | bogdanvlviv | 2016-10-27 | 7 | -11/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Mainly around `nil` [ci skip] | |||||
* | | | | removes unconventional "then" in case expression | Xavier Noria | 2016-11-13 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | revises style in recent code (of mine) | Xavier Noria | 2016-11-13 | 1 | -5/+7 | |
| |/ / |/| | | | | | | | | | | | This alternative case expressions read better for my taste, and look more uniform in a file where other similar case expressions are used (without dynamic clauses). | |||||
* | | | significant speedup of AC::Parameters#permit | Xavier Noria | 2016-11-12 | 2 | -1/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation of AC::Parameters#permit builds permitted hashes and then calls permit! on them. This filtering is recursive, so we call permit! on terminal branches, but then ascendants call permit! on themselves when the recursion goes up the stack, which recurses all the way down again because permit! is recursive itself. Repeat this for every parent node and you get some scary O-something going on that I don't even want to compute. Instead, since the whole point of the permit recursion is to build permitted hashes along the way and at that point you know you've just come up with a valid filtered version, you can already switch the toggle on the spot. I have seen 2x speedups in casual benchmarks with small structures. As the previous description shows, the difference in performance is going to be a function of the nesting. Note that that the involved methods are private and used only by permit. | |||||
* | | | adds a missing dot [ci skip] | Xavier Noria | 2016-11-11 | 1 | -1/+1 | |
| | | | ||||||
* | | | adds support for arbitrary hashes in strong parameters | Xavier Noria | 2016-11-11 | 3 | -0/+86 | |
| | | | ||||||
* | | | Merge pull request #26820 from y-yagi/add_bang_merge_to_parameters | Rafael França | 2016-11-10 | 3 | -0/+28 | |
|\ \ \ | |_|/ |/| | | add `ActionController::Parameters#merge!` | |||||
| * | | add `ActionController::Parameters#merge!` | yuuji.yaginuma | 2016-10-18 | 3 | -0/+28 | |
| | | | | | | | | | | | | | | | This method has the same behavior as `Hash#merge!`, returns current `ActionController::Parameters`. | |||||
* | | | Show what was the error when assertion has failed | Akira Matsuda | 2016-11-05 | 1 | -1/+1 | |
| | | | | | | | | | | | | this test case fails with ruby 2.4, so we want to see what's actually happening | |||||
* | | | Add more rubocop rules about whitespaces | Rafael Mendonça França | 2016-10-29 | 74 | -300/+300 | |
| | | | ||||||
* | | | Support plain loggers in DebugExceptions | Genadi Samokovarov | 2016-10-28 | 2 | -1/+20 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I have been seeing people setting `Logger` instances for `config.logger` and it blowing up on `rails/web-console` usage. Now, I doubt many folks are manually setting `ActionView::Base.logger`, but given that `DebugExceptions` is running in a pretty fragile environment already, having it crash (and being silent) in those cases can be pretty tricky to trace down. I'm proposing we verify whether the `ActionView::Base.logger` supports silencing before we try to do it, to save us the headache of tracing it down. | |||||
* | | | Fix :stopdoc: to :startdoc: [ci skip] | Ryuta Kamizono | 2016-10-28 | 1 | -1/+1 | |
| | | | ||||||
* | | | removes requires already present in active_support/rails | Xavier Noria | 2016-10-27 | 2 | -3/+0 | |
| | | | ||||||
* | | | let Regexp#match? be globally available | Xavier Noria | 2016-10-27 | 1 | -1/+0 | |
| | | | | | | | | | | | | | | | | | | Regexp#match? should be considered to be part of the Ruby core library. We are emulating it for < 2.4, but not having to require the extension is part of the illusion of the emulation. | |||||
* | | | remove unused `RedirectBackError` class | yuuji.yaginuma | 2016-10-27 | 1 | -8/+0 | |
| | | | | | | | | | | | | Follow up to 333bfd896e87862cece95deb1ef88132d5f54ba8 | |||||
* | | | Remove all Journey constant from public API | Rafael Mendonça França | 2016-10-26 | 5 | -7/+17 | |
| | | | | | | | | | | | | | | | | | | There were never public API only there by mistake. [ci skip] | |||||
* | | | Remove mona lisa image from the tests | Rafael Mendonça França | 2016-10-25 | 5 | -19/+19 | |
| |/ |/| | | | | | | | This image has copyright that we are not giving so it is better to use one image that we own the copyright. | |||||
* | | HSTS subdomains is now true, so let's fix documentation [ci skip] (#26870) | प्रथमेश Sonpatki | 2016-10-23 | 1 | -1/+1 | |
| | | | | | | - Followup of fda5afeb | |||||
* | | Soften this test since YAML.dump may produce keys in other orders. | Charles Oliver Nutter | 2016-10-21 | 1 | -6/+4 | |
| | | ||||||
* | | Revert "Undefine assings in IntegrationTest" | Rafael Mendonça França | 2016-10-21 | 2 | -10/+0 | |
|/ | | | | | | This reverts commit 5dde413e1d14c42eb87071db20d075a7b962cb01. Reason: The gem defines it so we don't need to remove | |||||
* | /s/integrations/integration [ci skip] (#26801) | प्रथमेश Sonpatki | 2016-10-16 | 1 | -1/+1 | |
| | ||||||
* | Merge pull request #26786 from codeodor/patch-1 | Eileen M. Uchitelle | 2016-10-15 | 3 | -1/+16 | |
|\ | | | | | Allow any key in Renderer environment hash | |||||
| * | Allow any key in Renderer environment hash | Sammy Larbi | 2016-10-15 | 3 | -1/+16 | |
| | | | | | | | | | | | | When rendering arbitrary templates, it is helpful to not overwrite `env` keys with nil if they don't match any found in the `RACK_KEY_TRANSLATION` This allows the developer to set the environment to exactly what is needed for rendering. | |||||
* | | Copy-edit the documentation | Rafael Mendonça França | 2016-10-15 | 1 | -4/+4 | |
| | | | | | | | | [ci skip] | |||||
* | | Make `process` a non-private method and update documentation. | Zach Aysan | 2016-10-15 | 1 | -98/+100 | |
|/ | ||||||
* | [ci skip] fix typo in Actionpack Changelog | Alex Kitchens | 2016-10-11 | 1 | -1/+1 | |
| | ||||||
* | ActionController::Parameters#deep_dup (#26567) | Pavel Evstigneev | 2016-10-11 | 2 | -0/+29 | |
| | | | | | | | | | | | * ActionController::Parameters#deep_dup * Tests for ActionController::Parameters#deep_dup * Fix test for ActionController::Parameters#deep_dup * More tests for ActionController::Parameters#deep_dup [Rafael Mendonça França + Pavel Evstigneev] | |||||
* | Add missing @, fix indents. [ci skip] | bogdanvlviv | 2016-10-10 | 1 | -6/+6 | |
| | ||||||
* | Remove deprecated support to non-keyword arguments in ↵ | Rafael Mendonça França | 2016-10-10 | 4 | -98/+19 | |
| | | | | | | `ActionDispatch::IntegrationTest`, `#process`, `#get`, `#post`, `#patch`, `#put`, `#delete`, and `#head`. | |||||
* | Remove deprecated `ActionDispatch::IntegrationTest#*_via_redirect`. | Rafael Mendonça França | 2016-10-10 | 3 | -142/+4 | |
| | ||||||
* | Remove deprecated `ActionDispatch::IntegrationTest#xml_http_request` | Rafael Mendonça França | 2016-10-10 | 3 | -134/+8 | |
| | ||||||
* | Remove deprecated support for passing `:path` and route path as stings in ↵ | Rafael Mendonça França | 2016-10-10 | 3 | -17/+7 | |
| | | | | `ActionDispatch::Routing::Mapper#match` | |||||
* | Remove deprecated support passing path as `nil` in ↵ | Rafael Mendonça França | 2016-10-10 | 3 | -8/+6 | |
| | | | | `ActionDispatch::Routing::Mapper#match` | |||||
* | Remove deprecated `cache_control` argument from ↵ | Rafael Mendonça França | 2016-10-10 | 3 | -18/+5 | |
| | | | | `ActionDispatch::Static#initialize` | |||||
* | Remove deprecated support to passing strings to the middleware stack | Rafael Mendonça França | 2016-10-10 | 4 | -60/+8 | |
| | ||||||
* | Remove deprecated code in ssl middleware | Rafael Mendonça França | 2016-10-10 | 3 | -60/+21 | |
| | ||||||
* | Remove deprecated code in ActionDispatch::Session::SessionRestoreError | Rafael Mendonça França | 2016-10-10 | 2 | -11/+10 | |
| | ||||||
* | Deprecated ActionDispatch::ParamsParser::ParamsParser | Rafael Mendonça França | 2016-10-10 | 8 | -36/+34 | |
| | | | | | | ActionDispatch::ParamsParser class was removed in favor of ActionDispatch::Http::Parameters so it is better to move the error constant to the new class. | |||||
* | Remove deprecated ActionDispatch::ParamsParser | Rafael Mendonça França | 2016-10-10 | 2 | -12/+5 | |
| | ||||||
* | Remove deprecated code in ActionDispatch::ParamsParser::ParseError | Rafael Mendonça França | 2016-10-10 | 2 | -17/+10 | |
| | ||||||
* | Remove deprecated access to mime types through constants | Rafael Mendonça França | 2016-10-10 | 3 | -38/+4 | |
| | ||||||
* | Remove deprecated support to non-keyword arguments #process | Rafael Mendonça França | 2016-10-10 | 3 | -181/+21 | |
| | ||||||
* | Remove deprecated `xml_http_request` and `xhr` methods | Rafael Mendonça França | 2016-10-10 | 3 | -30/+4 | |
| | ||||||
* | Remove deprecated methods in ActionController::Parameters | Rafael Mendonça França | 2016-10-10 | 3 | -27/+5 | |
| | ||||||
* | Remove deprecated comparing support with `ActionController::Parameters` | Rafael Mendonça França | 2016-10-10 | 3 | -17/+5 | |
| |