aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #36537 from quadule/fix-cookie-rotation-hash-pollutionKasper Timm Hansen2019-08-052-2/+19
|\ | | | | Fix cookie modification during rotation
| * Prevent serialized hash from being used as optionsMilo Winningham2019-06-221-2/+6
| |
| * Add test for cookie being modified by rotationMilo Winningham2019-06-221-0/+13
| |
* | Use media_type instead of content_type internallyEugene Kenny2019-08-046-4/+49
| | | | | | | | | | | | | | These calls to `content_type` were triggering the deprecation from c631e8d011a7cf3e7ade4e9e8db56d2b89bd530c in upgraded applications. We can use `media_type` in all of these cases to avoid the deprecation.
* | ConditionalGet needs time core_extRafael Mendonça França2019-08-021-0/+1
| |
* | Revert "MethodCallAssertions is a regular player of the team ↵Rafael Mendonça França2019-08-021-0/+4
| | | | | | | | | | | | ActiveSupport::TestCase now" This reverts commit 98d0f7ebd34b858f12a12dcf37ae54fdbb5cab64.
* | Revert "You give jruby_skip & rubinius_skip a good name"Rafael Mendonça França2019-08-021-0/+13
| | | | | | | | This reverts commit 8d2866bb80fbe81acb04f5b0c44f152f571fb29f.
* | You give jruby_skip & rubinius_skip a good nameAkira Matsuda2019-08-021-13/+0
| | | | | | | | | | | | | | | | This hack prevails everywhere in the codebase by being copy & pasted, and it's actually not a negative thing but a necessary thing for framework implementors, so it should better have a name and be a thing. And with this commit, activesupport/test/abstract_unit.rb now doesn't silently autoload AS::TestCase, so we're ready to establish clearner environment for running AS tests (probably in later commits)
* | MethodCallAssertions is a regular player of the team ActiveSupport::TestCase nowAkira Matsuda2019-08-021-4/+0
| | | | | | | | It's used everywhere, clean and mature enough
* | It may be better to explicitly require 'object/try' where we call `try`Akira Matsuda2019-08-011-0/+2
| | | | | | | | | | | | In most cases it works now without explicit require because it's accidentally required through active_support/core_ext/date_and_time/calculations.rb where we still call `try`, but that would stop working if we changed the Calculations implementation and remove the require call there.
* | Use `try` only when we're unsure if the receiver would respond_to the methodAkira Matsuda2019-08-014-5/+5
| |
* | Reduce method invocations and object allocations in head()Akira Matsuda2019-07-311-1/+1
| |
* | Reduce Array allocationsAkira Matsuda2019-07-311-2/+2
| |
* | Reduce block executionAkira Matsuda2019-07-311-3/+3
| |
* | Reduce method callsAkira Matsuda2019-07-311-2/+1
| |
* | Reduce Array assignment by not giving a name for unused `*args`Akira Matsuda2019-07-314-6/+6
| |
* | Reduce some more Hash#fetch + default object allocationsAkira Matsuda2019-07-312-3/+3
| |
* | Reduce Hash object creation when normalizing request envAkira Matsuda2019-07-311-2/+3
| |
* | Reduce object allocations in Middleware::StaticAkira Matsuda2019-07-311-11/+12
| |
* | Reduce unnecessary String creation by not `to_s`ing until nothing matchesAkira Matsuda2019-07-311-1/+1
| |
* | Reduce String allocation when finding controller classAkira Matsuda2019-07-311-1/+1
| |
* | No need to dup the payload for an instrumentationAkira Matsuda2019-07-311-1/+1
| |
* | Use match? where we don't need MatchDataAkira Matsuda2019-07-2921-33/+33
| |
* | Revert "Use assert_match / assert_no_match for asserting match"Akira Matsuda2019-07-291-6/+6
| | | | | | | | | | | | This reverts commit e9651deea4145f62224af56af027bfbb3e45e4cd. Now we're having both `=~` and `match?` for these objects, and it's nicer to have explicit tests for both of them
* | Add Mime::Type#match? that doesn't create MatchDataAkira Matsuda2019-07-292-1/+13
| |
* | Revert "Merge pull request #36785 from shes50103/fix_typo_actionpack_changelog"Ryuta Kamizono2019-07-281-1/+1
| | | | | | | | | | This reverts commit ac6f3c9299209ea4b2fa7c368ea1ff406735ca93, reversing changes made to 5b0ea95a1a8acc5054f9a58d324070303cbd19b9.
* | fix typo in actionpack CHANGELOG.mdshes501032019-07-281-1/+1
| |
* | Merge pull request #36545 from tomfakes/screenshot-updatesRafael Mendonça França2019-07-273-30/+110
|\ \ | | | | | | | | | HTML page save during screenshot and multiple shots per test
| * | Add code to save the HTML of the page being screenshotted during the ↵Tom Fakes2019-06-253-30/+110
| |/ | | | | | | | | | | | | | | | | | | | | `take_screenshot` method that is enabled by a new environment variable - RAILS_SYSTEM_TESTING_SCREENSHOT_HTML=1 Add the ability to call `take_screenshot` more than once in a single test by prefixing the name of the image file with a counter that is incremented on every `take_screenshot` call. This allows a developer to see their pages in sequence when trying to debug test errors. This does not affect the failure case where the prefix remains 'failures'
* | Use match? where we don't need MatchDataAkira Matsuda2019-07-276-10/+10
| | | | | | | | We're already running Performance/RegexpMatch cop, but it seems like the cop is not always =~ justice
* | Use assert_match / assert_no_match for asserting matchAkira Matsuda2019-07-271-6/+6
| |
* | Fix "warning: ambiguous first argument; put parentheses or a space even ↵yuuji.yaginuma2019-07-271-1/+1
| | | | | | | | after `/' operator"
* | Fix error 500 caused by ActionController::RoutingError (via fail-safe) when ↵Simone Carletti2019-07-261-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | POST parameters are invalid (#29985) * Reproduce error caused by malformed parameters Error: RequestFormat#test_format_does_not_throw_exceptions_when_invalid_POST_parameters: ActionDispatch::Http::Parameters::ParseError: 765: unexpected token at '{record:{content:24.12.1.146}}' /Users/weppos/Mirrors/rails/actionpack/lib/action_dispatch/http/parameters.rb:113:in `rescue in parse_formatted_parameters' /Users/weppos/Mirrors/rails/actionpack/lib/action_dispatch/http/parameters.rb:107:in `parse_formatted_parameters' /Users/weppos/Mirrors/rails/actionpack/lib/action_dispatch/http/request.rb:360:in `block in POST' /Users/weppos/.rvm/gems/ruby-2.3.3/gems/rack-2.0.3/lib/rack/request.rb:57:in `fetch' /Users/weppos/.rvm/gems/ruby-2.3.3/gems/rack-2.0.3/lib/rack/request.rb:57:in `fetch_header' /Users/weppos/Mirrors/rails/actionpack/lib/action_dispatch/http/request.rb:359:in `POST' /Users/weppos/Mirrors/rails/actionpack/lib/action_dispatch/http/parameters.rb:53:in `parameters' /Users/weppos/Mirrors/rails/actionpack/lib/action_dispatch/http/mime_negotiation.rb:62:in `block in formats' /Users/weppos/.rvm/gems/ruby-2.3.3/gems/rack-2.0.3/lib/rack/request.rb:57:in `fetch' /Users/weppos/.rvm/gems/ruby-2.3.3/gems/rack-2.0.3/lib/rack/request.rb:57:in `fetch_header' /Users/weppos/Mirrors/rails/actionpack/lib/action_dispatch/http/mime_negotiation.rb:60:in `formats' /Users/weppos/Mirrors/rails/actionpack/test/dispatch/request_test.rb:891:in `block in <class:RequestFormat>' See GH-29983 * Capture parameter parsing error output and test it This change prevents the log to be displayed in the tests. Moreover, the assertion against the debug ensures that the test effectively triggers the parsing error as expected. * Use a generic value in the test * Switch to assert_match [Simone Carletti + Rafael Mendonça França]
* | Merge pull request #36254 from sharang-d/remove-named-helpersRafael França2019-07-261-1/+1
|\ \ | | | | | | Use a single term instead of all terms used to describe path and URL helpers together
| * | Use a single term instead of all terms used to describe path and URL helpers ↵Sharang Dashputre2019-07-261-1/+1
| | | | | | | | | | | | together
* | | Merge pull request #36779 from Shopify/optimize-url-helper-creationRafael França2019-07-261-1/+1
|\ \ \ | | | | | | | | Optimize Journey::Route#glob?
| * | | Optimize Journey::Route#glob?Jean Boussier2019-07-261-1/+1
| |/ /
* / / Add `Vary: Accept` header when renderingst00122019-07-265-7/+60
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem description (quoted from @rafaelfranca's excellent explanation in https://github.com/rails/jquery-ujs/issues/318#issuecomment-88129005): > Let say that we requested /tasks/1 using Ajax, and the previous page has the same url. When we click the back button the browser tries to get the response from its cache and it gets the javascript response. With vary we "fix" this behavior because we are telling the browser that the url is the same but it is not from the same type what will skip the cache. And there's a Rails issue discussing about this problem as well https://github.com/rails/rails/issues/25842 Also, according to [RFC 7231 7.1.4](https://tools.ietf.org/html/rfc7231#section-7.1.4) > An origin server SHOULD send a Vary header field when its algorithm > for selecting a representation varies based on aspects of the request > message other than the method and request target we should add `Vary: Accept` header when determining content based on the `Accept` header. Although adding such header by default could cause unnecessary cache invalidation. But this PR only adds the header if: - The format param is not provided - The request is a `xhr` request - The request has accept headers and the headers are valid So if the user - sends request with explicit format, like `/users/1.json` - or sends a normal request (non xhr) - or doesn't specify accept headers then the header won't be added. See the discussion in https://github.com/rails/rails/issues/25842 and https://github.com/rails/rails/pull/36213 for more details.
* | Merge pull request #36300 from okuramasafumi/make-handle-options-privateRafael França2019-07-261-22/+22
|\ \ | | | | | | Make `handle_options` method private
| * | Make `handle_options` method privateOKURA Masafumi2019-05-181-22/+22
| | | | | | | | | | | | | | | `handle_options` method in `CookieJar` is used internal only, so it should be private.
* | | Fix flaky test ActionControllerBaseRenderTest#test_direct_render_to_stringFumiaki MATSUSHIMA2019-07-261-4/+20
| | |
* | | Merge pull request #36412 from robotdana/compact_blankRafael Mendonça França2019-07-252-0/+30
|\ \ \ | | | | | | | | | | | | Add compact_blank shortcut for reject(&:blank?)
| * | | Add compact_blank shortcut for reject(&:blank?)Dana Sherson2019-06-052-0/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I frequently find myself having to .compact but for blank. which means on an array reject(&:blank?) (this is fine), or, on a hash `.reject { |_k, v| v.blank? }` which is slightly more frustrating and i usually write it as .reject(&:blank?) first and am confused when it's trying to check if the keys are blank. I've added the analagous .compact_blank! where there's a reject! to build on (there's also a reject! in Set, but there's no other core_ext touching Set so i've left that alone)
* | | | fix `follow_redirect!` not using the same HTTP verb on 307 redirection:Edouard CHIN2019-07-253-3/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - According to the HTTP 1.1 spec, the 307 redirection guarantees that the method and the body will not be changed during redirection. This PR fixes that since follow_redirect! would always follow the redirection my making a GET request. Ref https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/307
* | | | Stop setting a default Capybara app hostGeorge Claghorn2019-07-244-33/+38
| | | | | | | | | | | | It's intended not to be set if Capybara starts the app server itself. Base Rails-generated URLs off of Capybara.current_session.server_url instead.
* | | | Define the `url_options` needed for SytemTest inside the route proxy:Edouard CHIN2019-07-241-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - I made a change in https://github.com/rails/rails/pull/36691 to delegate route helper to a proxy class. This didn't take into account that the `url_options` we redefine in SystemTest would be ignored. This PR fixes that by definin the url_options inside the proxy
* | | | [ActionController] Fix send_file example for 404Yuya Tanaka2019-07-191-1/+1
| | | |
* | | | Add support for script-src-attr / elem and style-src-attr / elem directivesyuuji.yaginuma2019-07-182-0/+28
| | | | | | | | | | | | | | | | | | | | These directives can be used in Chrome 75. Ref: https://www.chromestatus.com/feature/5141352765456384
* | | | Merge pull request #36691 from Edouard-chin/ec-system-test-routeRafael França2019-07-172-6/+13
|\ \ \ \ | | | | | | | | | | Don't include routes helpers inside System test class:
| * | | | Don't include routes helpers inside System test class:Edouard CHIN2019-07-162-6/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - https://github.com/rails/rails/pull/36283 made a change to make SystemTest inherits from ActiveSupport::TestCase instead of ActionDispatch::IntegrationTest. With this change, the route helpers are now directly included inside the SystemTest class. This causes an edge case in case you have a routes whos name starts with `test_`, minitest will consider it as a test and will try to run it https://github.com/seattlerb/minitest/blob/ab39d35fb4e84eb866ed9c4ecb707cbf3889de42/lib/minitest/test.rb#L66 This PR uses a proxy and deleted missing method to a dummy class that has all the route helpers.
generated by cgit v1.2.3 (git 2.25.1) at 2024-04-30 09:05:34 +0000