diff options
author | Vipul A M <vipulnsward@gmail.com> | 2016-08-19 19:38:26 +0530 |
---|---|---|
committer | Vipul A M <vipulnsward@gmail.com> | 2016-11-12 15:47:39 -0500 |
commit | 89fab56597c335bb49887563b9a98386b5171574 (patch) | |
tree | 36d593befb78ec7938780687bdc81014f880546e /actionpack | |
parent | 26dd9b26ab7317f94fd285245879e888344143b2 (diff) | |
download | rails-89fab56597c335bb49887563b9a98386b5171574.tar.gz rails-89fab56597c335bb49887563b9a98386b5171574.tar.bz2 rails-89fab56597c335bb49887563b9a98386b5171574.zip |
Format and send logs to logger.fatal from DebugExceptions instead of calling fatal multiple times. Expose tags_text from TaggedLogging to be used for log formatting
Fixes #26134
Diffstat (limited to 'actionpack')
-rw-r--r-- | actionpack/CHANGELOG.md | 8 | ||||
-rw-r--r-- | actionpack/lib/action_dispatch/middleware/debug_exceptions.rb | 6 |
2 files changed, 13 insertions, 1 deletions
diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md index b539c893e3..efaa1f4804 100644 --- a/actionpack/CHANGELOG.md +++ b/actionpack/CHANGELOG.md @@ -1,3 +1,11 @@ +* Fixes multiple calls to `logger.fatal` instead of a single call, + for every line in an exception backtrace, when printing trace + from `DebugExceptions` middleware. + + Fixes #26134 + + *Vipul A M* + * Add support for arbitrary hashes in strong parameters: ```ruby diff --git a/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb b/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb index 1a9018fe0c..1c720c5a8e 100644 --- a/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb +++ b/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb @@ -175,7 +175,11 @@ module ActionDispatch end def log_array(logger, array) - array.map { |line| logger.fatal line } + if logger.formatter && logger.formatter.respond_to?(:tags_text) + logger.fatal array.join("\n#{logger.formatter.tags_text}") + else + logger.fatal array.join("\n") + end end def logger(request) |