aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack
Commit message (Collapse)AuthorAgeFilesLines
* [ci skip] Don't use TrueClass, FalseClass in docsclaudiob2015-07-021-6/+0
| | | | | | | | | This sort of documentation style comes from 2009, probably due to the merging of merb (see https://github.com/rails/rails/commit/38b608ecab2441cd0c4e75bc08bdf57fcf85dd71#diff-017d9bc9b1d2bdae199b938d72c15488R120). Rails follows Ruby's convention to define which values are "truthy" or "falsey", so there is no need to specify that the returned value must strictly be a TrueClass or FalseClass. /cc @fxn
* [ci skip] Improve the url_for documentationRoque Pinel2015-07-011-3/+19
| | | | | | | | | Clarify the `url_for` usage in mailers. Re-add the documentation about `url_for` and Route's path parameters, first introduced by 5c4f1859970d06228a0b67cad6d4486c1526ef2a. This was reported on #15097 and until it is decided to deprecate it or not, I believe the documentation should exist.
* Improve error messages in cookies_testeileencodes2015-06-271-3/+3
| | | | | | | | | | | | | | | Using `assert_predicate` and `assert_match` instead of just `assert` is preferrable because better error messages are output. In the case of `assert response.cookies.empty?` the error message was `Failed assertion, no message given.` but now with `assert_predicate` it will be `Expected {"user_name"=>"david"} to be empty?.` For `assert_match(/user_name=david/, response.headers["Set-Cookie"])` as well, the message returned was unhelpful - `Failed assertion, no message given.` but now will tell what was expected and what was returned with `Expected /user_name=david/ to match "user_name=nope; path=/".`
* Merge pull request #20276 from davetron5000/revert-head-on-no-templateKasper Timm Hansen2015-06-272-2/+38
|\ | | | | Allow default_render to take a block to customize behavior when there's no template
| * Override default_render's behavior with a blockDave Copeland2015-06-202-2/+38
| | | | | | | | | | | | | | | | | | | | In 0de4a23 the behavior when there is a missing template was changed to not raise an error, but instead head :no_content. This is a breaking change and some gems rely on this happening. To allow gems and other code to work around this, allow `default_render` to take a block which, if provided, will execute the contents of that block instead of doing the `head :no_content`.
* | Merge pull request #20664 from vngrs/remove_mistaken_end_from_docClaudio B.2015-06-221-1/+1
|\ \ | | | | | | Remove mistaken end from controller_path doc [ci skip]
| * | Remove mistaken end from controller_path doc [ci skip]Mehmet Emin İNAÇ2015-06-221-1/+1
| | |
* | | Merge pull request #19431 from hmarr/head-routingRafael Mendonça França2015-06-222-4/+4
|\ \ \ | |/ / |/| | Respect routing precedence for HEAD requests
| * | Respect routing precedence for HEAD requestsHarry Marr2015-03-202-4/+4
| | | | | | | | | | | | | | | | | | | | | Fixes the issue described in #18764 - prevents Rack middleware from swallowing up HEAD requests that should have been matched by a higher-precedence `get` route, but still allows Rack middleware to respond to HEAD requests.
* | | Merge pull request #20659 from ↵Yves Senn2015-06-221-2/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | vngrs/strong_parameters_unpermitted_parameters_wrong_doc_fix Fix the documentation about ActionController::UnpermittedParameters [ci skip]
| * | | Fix the documentation about ActionController::UnpermittedParameters [ci skip]Mehmet Emin İNAÇ2015-06-221-2/+4
|/ / /
* | / Fix the documentation about ActionController::ParameterMissing [ci skip]Mehmet Emin İNAÇ2015-06-221-5/+5
| |/ |/|
* | Revert "Merge pull request #20584 from arthurnn/fix_url"Arthur Neves2015-06-173-19/+4
| | | | | | | | | | | | | | | | This reverts commit 0b3397872582f2cf1bc6960960a6393f477c55e6, reversing changes made to 56d52e3749180e6c1dcf7166adbad967470aa78b. As pointed out on the PR, this will hide development mistakes too, which is not ideal.
* | Merge pull request #20584 from arthurnn/fix_urlArthur Nogueira Neves2015-06-163-4/+19
|\ \ | | | | | | Catch InvalidURIError on bad paths on redirect.
| * | Catch InvalidURIError on bad paths on redirect.Arthur Neves2015-06-163-4/+19
| | | | | | | | | | | | | | | Handle URI::InvalidURIError errors on the redirect route method, so it wont raise a 500 if a bad path is given.
* | | Fix the comment about attr_reader of headers [ci skip]Mehmet Emin İNAÇ2015-06-161-1/+1
|/ /
* | remove `header=` on the response object.Aaron Patterson2015-06-153-13/+16
| | | | | | | | | | | | People should be free to mutate the header object, but not to set a new header object. That header object may be specific to the webserver, and we need to hide it's internals.
* | set the default charset in response initializeAaron Patterson2015-06-151-4/+12
| | | | | | | | | | this way we don't have to mutate the instance (as much) when writing a rack response
* | Deprecate passing hash as first parameter into ActionController::HeadMehmet Emin İNAÇ2015-06-155-12/+47
| |
* | Fix flakyness.Kasper Timm Hansen2015-06-151-0/+1
| | | | | | | | Brought on by my own stupidity :)
* | A few documentation edits [ci skip]Robin Dupret2015-06-152-10/+12
| |
* | quick pass over changelogs. [ci skip]Yves Senn2015-06-151-4/+4
| |
* | Merge pull request #20559 from mtsmfm/fix-header-modification-by-sslGuillermo Iguaran2015-06-142-1/+12
|\ \ | | | | | | ActionDispatch::SSL should keep original header's behavior
| * | ActionDispatch::SSL should keep original header's behaviorFumiaki MATSUSHIMA2015-06-142-1/+12
| | | | | | | | | | | | | | | | | | `ActionDispatch::SSL` changes headers to `Hash`. So some headers will be broken if there are some middlewares on ActionDispatch::SSL and if it uses `Rack::Utils::HeaderHash`.
* | | Merge pull request #20558 from prathamesh-sonpatki/missing-header-wordKasper Timm Hansen2015-06-141-1/+1
|\ \ \ | |/ / |/| | Add missing "header" word in documentation of Token#authentication_request [ci skip]
| * | Add missing "header" word in documentation of Token#authentication_request ↵Prathamesh Sonpatki2015-06-141-1/+1
| | | | | | | | | | | | [ci skip]
* | | don't hold a reference to `env` in the options objectAaron Patterson2015-06-131-13/+11
| | | | | | | | | | | | | | | I want to decouple Rails from the rack ENV as much as possible. We should try to keep as few references to the env as possible
* | | Handle param-parsing errors from Rack in ExceptionWrapperGrey Baker2015-06-122-1/+9
|/ /
* | Merge pull request #20480 from senny/test_runnerYves Senn2015-06-121-0/+4
|\ \ | | | | | | use our own runner for Rails framework components `bin/test`
| * | select the AR adapter through `bin/test`.Yves Senn2015-06-111-0/+1
| | |
| * | use our runner (`bin/test`) for framework components.Yves Senn2015-06-111-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds a script `bin/test` to most Rails framework components. The script uses the rails minitest plugin to augment the runner. See https://github.com/rails/rails/pull/19571 for details about the plugin. I did not yet add `bin/test` for activerecord, activejob and railties. These components rely on specific setup performed in the rake-tasks.
* | | Update RDoc for ActionController::TestCase for kwargs.Victor Costan2015-06-121-1/+1
| | |
* | | Merge pull request #20522 from colby-swandale/doc-updateSean Griffin2015-06-111-1/+1
|\ \ \ | | | | | | | | fixed sring to be string in ActiveRecord::Base params documentation [ci skip]
| * | | fixed sring to be string in ActiveRecord::Base params documentationColby Swandale2015-06-121-1/+1
| | | |
* | | | Mention that doing nothing in Rails API controllers returns 204Santiago Pastorino2015-06-111-1/+1
| | | |
* | | | Return 204 if render is not called in API controllersJorge Bejar2015-06-115-6/+31
| | | |
* | | | Add test coverage for implicit render in empty actionsJorge Bejar2015-06-111-0/+14
| | | |
* | | | Include ParamsWrapper in AC::APIJorge Bejar2015-06-112-1/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ParamsWrapper was initially removed from API controllers according to the following discusision: https://github.com/rails-api/rails-api/issues/33 However, we're including it again so Rails API devs can decide whether to enable or disable it.
* | | | Add CHANGELOG entries for API apps functionalitySantiago Pastorino2015-06-111-0/+6
| | | |
* | | | Fix MimeResponds example in AC::API documentationSantiago Pastorino2015-06-111-3/+5
| | | |
* | | | Revert changes related with api apps in RouteWrapperJorge Bejar2015-06-111-11/+1
| | | | | | | | | | | | | | | | | | | | See the following commit to have context about this change: https://github.com/rails/rails/commit/757a2bc3e3e52a5d9418656928db993db42b741b
* | | | Rename test methods in api conditional get controller testsJorge Bejar2015-06-111-2/+2
| | | |
* | | | Do not say that Api Controllers are faster than regular ones in docsJorge Bejar2015-06-111-4/+4
| | | |
* | | | Remove Compatibility module since we don't remember why it was added :smile:Jorge Bejar2015-06-112-20/+0
| | | |
* | | | Routes resources avoid :new and :edit endpoints if api_only is enabledJorge Bejar2015-06-113-12/+110
| | | |
* | | | Remove extra whitespacesSantiago Pastorino2015-06-111-1/+1
| | | |
* | | | Use new hash syntaxSantiago Pastorino2015-06-112-7/+7
| | | |
* | | | Refactor internal? to query internal_controller? and internal_asset? methodsSantiago Pastorino2015-06-111-1/+11
| | | |
* | | | Remove Unneeded ApiPublicExceptions middleware, PublicExceptions already ↵Santiago Pastorino2015-06-113-84/+0
| | | | | | | | | | | | | | | | does the work
* | | | Remove api_rendering is not neededSantiago Pastorino2015-06-113-19/+1
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 09:06:09 +0000