diff options
| author | eileencodes <eileencodes@gmail.com> | 2015-06-27 10:38:45 -0400 |
|---|---|---|
| committer | eileencodes <eileencodes@gmail.com> | 2015-06-27 16:48:20 -0400 |
| commit | 4d7b50707376b09188b545043e893f275dfd84e0 (patch) | |
| tree | 7245ba3115c8419a863cef9e55e4ba5b19d7869e /actionpack | |
| parent | 991e98f5640874a9bda41855af4f9315aff8260a (diff) | |
| download | rails-4d7b50707376b09188b545043e893f275dfd84e0.tar.gz rails-4d7b50707376b09188b545043e893f275dfd84e0.tar.bz2 rails-4d7b50707376b09188b545043e893f275dfd84e0.zip | |
Improve error messages in cookies_test
Using `assert_predicate` and `assert_match` instead of just `assert` is
preferrable because better error messages are output.
In the case of `assert response.cookies.empty?` the error message was
`Failed assertion, no message given.` but now with `assert_predicate` it
will be `Expected {"user_name"=>"david"} to be empty?.`
For `assert_match(/user_name=david/,
response.headers["Set-Cookie"])` as well, the message returned was
unhelpful - `Failed assertion, no message given.` but now will tell what
was expected and what was returned with `Expected /user_name=david/ to
match "user_name=nope; path=/".`
Diffstat (limited to 'actionpack')
| -rw-r--r-- | actionpack/test/dispatch/cookies_test.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/actionpack/test/dispatch/cookies_test.rb b/actionpack/test/dispatch/cookies_test.rb index 6223a52a76..aca28ae8d1 100644 --- a/actionpack/test/dispatch/cookies_test.rb +++ b/actionpack/test/dispatch/cookies_test.rb @@ -280,7 +280,7 @@ class CookiesTest < ActionController::TestCase def test_setting_the_same_value_to_cookie request.cookies[:user_name] = 'david' get :authenticate - assert response.cookies.empty? + assert_predicate response.cookies, :empty? end def test_setting_the_same_value_to_permanent_cookie @@ -360,7 +360,7 @@ class CookiesTest < ActionController::TestCase def test_delete_unexisting_cookie request.cookies.clear get :delete_cookie - assert @response.cookies.empty? + assert_predicate @response.cookies, :empty? end def test_deleted_cookie_predicate @@ -378,7 +378,7 @@ class CookiesTest < ActionController::TestCase def test_cookies_persist_throughout_request response = get :authenticate - assert response.headers["Set-Cookie"] =~ /user_name=david/ + assert_match(/user_name=david/, response.headers["Set-Cookie"]) end def test_set_permanent_cookie |