aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller/session
Commit message (Collapse)AuthorAgeFilesLines
* Session tests belong under dispatch folderJoshua Peek2009-04-213-435/+0
|
* Makes rails-dev-boost work againCarl Lerche & Yehuda Katz2009-04-141-2/+3
|
* Bring abstract_controller up to date with rails/masterCarl Lerche & Yehuda Katz2009-04-133-18/+72
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolved all the conflicts since 2.3.0 -> HEAD. Following is a list of commits that could not be applied cleanly or are obviated with the abstract_controller refactor. They all need to be revisited to ensure that fixes made in 2.3 do not reappear in 3.0: 2259ecf368e6a6715966f69216e3ee86bf1a82a7 AR not available * This will be reimplemented with ActionORM or equivalent 06182ea02e92afad579998aa80144588e8865ac3 implicitly rendering a js response should not use the default layout [#1844 state:resolved] * This will be handled generically 893e9eb99504705419ad6edac14d00e71cef5f12 Improve view rendering performance in development mode and reinstate template recompiling in production [#1909 state:resolved] * We will need to reimplement rails-dev-boost on top of the refactor; the changes here are very implementation specific and cannot be cleanly applied. The following commits are implicated: 199e750d46c04970b5e7684998d09405648ecbd4 3942cb406e1d5db0ac00e03153809cc8dc4cc4db f8ea9f85d4f1e3e6f3b5d895bef6b013aa4b0690 e3b166aab37ddc2fbab030b146eb61713b91bf55 ae9f258e03c9fd5088da12c1c6cd216cc89a01f7 44423126c6f6133a1d9cf1d0832b527e8711d40f 0cb020b4d6d838025859bd60fb8151c8e21b8e84 workaround for picking layouts based on wrong view_paths [#1974 state:resolved] * The specifics of this commit no longer apply. Since it is a two-line commit, we will reimplement this change. 8c5cc66a831aadb159f3daaffa4208064c30af0e make action_controller/layouts pick templates from the current instance's view_paths instead of the class view_paths [#1974 state:resolved] * This does not apply at all. It should be trivial to apply the feature to the reimplemented ActionController::Base. 87e8b162463f13bd50d27398f020769460a770e3 fix HTML fallback for explicit templates [#2052 state:resolved] * There were a number of patches related to this that simply compounded each other. Basically none of them apply cleanly, and the underlying issue needs to be revisited. After discussing the underlying problem with Koz, we will defer these fixes for further discussion.
| * just kill brittle testJoshua Peek2009-03-241-21/+0
| |
| * Better error message to try to figure out why the CI build is failingJoshua Peek2009-03-151-1/+11
| |
| * Fix brittle Time.now mockJoshua Peek2009-03-151-16/+4
| |
| * reset_session should force a new session id to be generated [#2173]Joshua Peek2009-03-091-16/+24
| |
| * Expected cookie value should also be escaped.moro2009-02-211-1/+1
| | | | | | | | | | | | | | | | Ruby 1.9 compat for test. [#1965 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
| * Remove space from the test name [#1953 state:resolved]Mike Gunderloy2009-02-121-1/+1
| | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
| * Update bundled Rack for Ruby 1.9 spec changesJoshua Peek2009-02-071-6/+8
| |
| * Temporarily bundle Rack 1.0 prerelease for testingJoshua Peek2009-02-071-4/+4
| |
| * Ensure session id is set in session options hash [#1880 state:resolved]Joshua Peek2009-02-062-1/+36
| |
* | Some merge cleanupYehuda Katz2009-02-021-1/+1
| |
* | Merge commit 'rails/3-0-unstable'Yehuda Katz2009-01-302-10/+11
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/base.rb actionpack/lib/action_dispatch/http/mime_type.rb actionpack/lib/action_dispatch/http/request.rb actionpack/lib/action_view/base.rb actionpack/lib/action_view/paths.rb actionpack/test/controller/session/cookie_store_test.rb actionpack/test/dispatch/rack_test.rb actionpack/test/dispatch/request_test.rb
| * Move HTTP libs and middleware into ActionDispatch componentJoshua Peek2009-01-272-10/+10
| |
* | Deprecation tests for f17c876 [#1801 state:resolved]Mike Gaffney2009-01-291-0/+58
| | | | | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* | Session cookie header should always be set if :expire_after option is specifiedPratik Naik2009-01-281-4/+32
|/
* Restore cookie store httponly default to true. Remove extraneous dup of ↵Cody Fauser2009-01-201-2/+2
| | | | | | options on initialization [#1784 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Fix randomly failing cookie store testsFrederick Cheung2008-12-261-5/+4
| | | | | Marshal.dump(Marshal.load(marshaled_hash)) is not guarenteed to be equal to marshaled_hash because of the lack of ordering of hash
* Fix reset_session with lazy cookie stores [#1601 state:resolved]Matt Bauer2008-12-202-1/+46
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Persistent session identifier support for CookieSessionStore and API compat. ↵Lourens Naude2008-12-181-2/+24
| | | | | | with the server side stores [#1591 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Switch to Rack based session stores.Joshua Peek2008-12-152-402/+153
|
* Use autoload instead of explicit requires for ActionControllerJoshua Peek2008-11-232-6/+0
|
* Move the cookie store to use the MessageVerifier class.Michael Koziarski2008-11-231-11/+2
| | | | This removes support for ancient cookie-store generated cookies which were double escaped.
* Work around ruby 1.9 segfaultJeremy Kemper2008-11-071-0/+1
|
* Added support for http_only cookies in cookie_store Added unit tests for ↵Pelle Braendgaard2008-09-171-1/+52
| | | | | | | secure and http_only cookies in cookie_store Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1046 state:committed]
* Fix file permissionsTarmo Tänav2008-07-311-0/+0
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Revert "Lazy load cache and session stores"David Heinemeier Hansson2008-06-121-1/+1
| | | | This reverts commit 19895f087c338d8385dff9d272d30fb87cb10330.
* Lazy load cache and session storesPratik Naik2008-06-101-1/+1
|
* Don't double-escape cookie store data. Don't split cookie values with ↵Rich Cavanaugh2008-05-121-2/+14
| | | | | | newlines into an array. [#130 state:resolved] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Implement increment/decrement on cache storage engines, using read/write by ↵Tobias Lütke2008-04-291-3/+2
| | | | default and using atomic command on memcache
* Ruby 1.9 compat: cookie store delete sets nil value instead of empty stringJeremy Kemper2008-01-071-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8589 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* require abstract_unit directly since test is in load pathJeremy Kemper2008-01-052-2/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Make sure that cookie sessions use a secret that is at least 30 chars in ↵Michael Koziarski2007-11-211-0/+19
| | | | | | length. [Koz] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Skip memcache tests unless it's installedJeremy Kemper2007-10-151-0/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Wrap test with uses_mochaJeremy Kemper2007-10-141-2/+4
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Memcached sessions: add session data on initialization; don't silently ↵Jeremy Kemper2007-10-141-0/+178
| | | | | | discard exceptions; add unit tests. Closes #9823. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Parse url-encoded and multipart requests ourselves instead of delegating to CGI.Jeremy Kemper2007-05-181-4/+3
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Shine some sunlight on the CGI extensions. Remove unused CGI#session.Jeremy Kemper2007-05-151-1/+1
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6733 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Cookie session store: ensure that new sessions doesn't reuse data from a ↵Jeremy Kemper2007-03-141-0/+13
| | | | | | deleted session in the same request. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Cookie session store: raise ArgumentError when :session_key is blank.Jeremy Kemper2007-03-131-0/+6
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Cookie store: use OpenSSL::HMAC instead of basic hash. Introduce :secret ↵Jeremy Kemper2007-03-031-21/+49
| | | | | | block and :digest option. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6296 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Cookie store: test that >4K raises CookieOverflow and that unverifiable ↵Jeremy Kemper2007-03-031-13/+43
| | | | | | cookies are automatically deleted. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6294 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Cookie session store: empty and unchanged sessions don't write a cookie.Jeremy Kemper2007-02-251-1/+15
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* CGI escape the session cookie.Jeremy Kemper2007-02-221-2/+2
| | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
* Introduce a cookie-based session store as the Rails default. Sessions ↵Jeremy Kemper2007-02-211-0/+137
typically contain at most a user_id and flash message; both fit within the 4K cookie size limit. A secure hash is included with the cookie to ensure data integrity (a user cannot alter his user_id without knowing the secret key included in the hash). If you have more than 4K of session data or don't want your data to be visible to the user, pick another session store. Cookie-based sessions are dramatically faster than the alternatives. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de