aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/test/controller/render_json_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Use media_type instead of content_type internallyEugene Kenny2019-08-041-0/+18
| | | | | | | These calls to `content_type` were triggering the deprecation from c631e8d011a7cf3e7ade4e9e8db56d2b89bd530c in upgraded applications. We can use `media_type` in all of these cases to avoid the deprecation.
* Remove unnecessary require pathname from actionpack controller specsAbhay Nikam2019-06-021-1/+0
|
* Change `ActionDispatch::Response#content_type` returning Content-Type header ↵yuuji.yaginuma2019-06-011-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | as it is Since #35709, `Response#conten_type` returns only MIME type correctly. It is a documented behavior that this method only returns MIME type, so this change seems appropriate. https://github.com/rails/rails/blob/39de7fac0507070e3c5f8b33fbad6fced84d97ed/actionpack/lib/action_dispatch/http/response.rb#L245-L249 But unfortunately, some users expect this method to return all Content-Type that does not contain charset. This seems to be breaking changes. We can change this behavior with the deprecate cycle. But, in that case, a method needs that include Content-Type with additional parameters. And that method name is probably the `content_type` seems to properly. So I changed the new behavior to more appropriate `media_type` method. And `Response#content_type` changed (as the method name) to return Content-Type header as it is. Fixes #35709. [Rafael Mendonça França & Yuuji Yaginuma ]
* Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* Add more rubocop rules about whitespacesRafael Mendonça França2016-10-291-1/+1
|
* Add three new rubocop rulesRafael Mendonça França2016-08-161-1/+1
| | | | | | | | Style/SpaceBeforeBlockBraces Style/SpaceInsideBlockBraces Style/SpaceInsideHashLiteralBraces Fix all violations in the repository.
* Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty linesRyuta Kamizono2016-08-071-1/+0
|
* modernizes hash syntax in actionpackXavier Noria2016-08-061-11/+11
|
* applies new string literal convention in actionpack/testXavier Noria2016-08-061-21/+21
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Stop using deprecated `render :text` in testPrem Sichanugrist2015-07-171-1/+1
| | | | | | | | | This will silence deprecation warnings. Most of the test can be changed from `render :text` to render `:plain` or `render :body` right away. However, there are some tests that needed to be fixed by hand as they actually assert the default Content-Type returned from `render :body`.
* Migrating xhr methods to keyword arguments syntaxKir Shatrov2015-02-011-2/+2
| | | | | | | | | | | | in `ActionController::TestCase` and `ActionDispatch::Integration` Old syntax: `xhr :get, :create, params: { id: 1 }` New syntax example: `get :create, params: { id: 1 }, xhr: true`
* Address CVE-2014-4671 (JSONP Flash exploit)Greg Campbell2014-07-091-1/+1
| | | | | | Adds a comment before JSONP callbacks. See http://miki.it/blog/2014/7/8/abusing-jsonp-with-rosetta-flash/ for more details on the exploit in question.
* CSRF protection from cross-origin <script> tagsJeremy Kemper2013-12-171-2/+2
| | | | Thanks to @homakov for sounding the alarm about JSONP-style data leaking
* Add changelog entry for jsonp mimetype change, fix failing testCarlos Antonio da Silva2012-04-291-1/+1
| | | | Fix failing test: Mime::JS generates "text/javascript"
* Merge pull request #2321 from omjokine/masterJosé Valim2012-04-291-1/+1
|\ | | | | JSONP should use mimetype application/javascript
| * fixed test case test_render_json_with_callback to use content_type ↵Olli Jokinen2011-07-281-1/+1
| | | | | | | | application/javascript
* | Moving to logger methods to ActiveSupport LoggerKarunakar (Ruby)2011-12-241-1/+2
| |
* | Revert the serializers API as other alternatives are now also under discussionJosé Valim2011-11-251-48/+0
| |
* | Rely solely on active_model_serializer and remove the fancy constant lookup.José Valim2011-11-231-1/+15
| |
* | Initial commit of serializer supportJose and Yehuda2011-10-151-0/+34
|/
* render_to_string must ensure that response_bodyNeeraj Singh2011-01-251-0/+10
| | | | | | | | is nil [ #5875 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* renderer calls object.to_json when rendering :json => object [#5655 ↵Diego Carrion2010-09-271-0/+13
| | | | | | state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Always downstream given options in :json, :xml and :js renderers and add ↵José Valim2010-04-221-0/+18
| | | | tests for it.
* Cleanup render callstack and make render(:json => {}, :status => 401) work ↵José Valim2010-02-241-0/+10
| | | | again.
* Namespace TestControllers inside their test case classJoshua Peek2009-09-191-27/+31
|
* Ported over render :file tests.Yehuda Katz + Carl Lerche2009-05-131-0/+80
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-09 05:54:09 +0000