aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/lib/action_dispatch/middleware/session/abstract_store.rb
Commit message (Collapse)AuthorAgeFilesLines
* Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-131-2/+0
| | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* [Action Pack] require => require_relativeAkira Matsuda2017-10-211-2/+2
| | | | | This basically reverts e9fca7668b9eba82bcc832cb0061459703368397, d08da958b9ae17d4bbe4c9d7db497ece2450db5f, d1fe1dcf8ab1c0210a37c2a78c1ee52cf199a66d, and 68eaf7b4d5f2bb56d939f71c5ece2d61cf6680a3
* Use frozen string literal in actionpack/Kir Shatrov2017-07-291-0/+2
|
* [Action Dispatch] require => require_relativeAkira Matsuda2017-07-011-2/+2
|
* [docs] fix ActionDispatch documentationHrvoje Šimić2017-03-131-1/+1
|
* Reduce string objects by using \ instead of + or << for concatenating stringsAkira Matsuda2017-01-121-2/+2
| | | | (I personally prefer writing one string in one line no matter how long it is, though)
* Privatize unneededly protected methods in Action PackAkira Matsuda2016-12-241-6/+5
|
* Remove deprecated code in ActionDispatch::Session::SessionRestoreErrorRafael Mendonça França2016-10-101-11/+1
|
* applies remaining conventions across the projectXavier Noria2016-08-061-1/+0
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-6/+6
|
* applies new string literal convention in actionpack/libXavier Noria2016-08-061-6/+6
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Deprecate exception#original_exception in favor of exception#causeYuki Nishijima2015-11-031-6/+14
|
* stop using deprecated Abstract::ID classAaron Patterson2015-09-041-1/+1
|
* use a request object in the session middlewareAaron Patterson2015-08-221-4/+8
| | | | | This commit allows us to use one request object rather than allocating multiple request objects to deal with the session.
* Use Encoding::UTF_8 constant :do_not_litter:Akira Matsuda2013-01-281-1/+1
|
* Revert cb3181e - no longer required.Mark J. Titorenko2013-01-081-2/+0
|
* Avoid Rack security warning no secret providedSantiago Pastorino2013-01-081-0/+2
| | | | This avoids "SECURITY WARNING: No secret option provided to Rack::Session::Cookie."
* load active_support/core_ext/object/blank in active_support/railsXavier Noria2012-08-021-1/+0
|
* session creation methods to a moduleAaron Patterson2012-05-041-6/+9
|
* bread AD::Request::Session to it's own file, consolidate HASH OF DOOM lookupsAaron Patterson2012-05-031-150/+1
|
* extract options finding to a methodAaron Patterson2012-05-021-4/+7
|
* testing session store behaviorAaron Patterson2012-05-021-7/+19
|
* initialize instance variablesAaron Patterson2012-05-021-6/+5
|
* converted session hash to delegationAaron Patterson2012-05-021-21/+19
|
* session hash importedAaron Patterson2012-05-021-15/+111
|
* oops, forgot some semicolonsAaron Patterson2012-05-021-3/+3
|
* remove unused ivarAaron Patterson2012-05-021-4/+3
|
* use hash fetches to populate the :id valueAaron Patterson2012-05-021-12/+7
|
* imported options, switched to object compositionAaron Patterson2012-05-021-13/+56
|
* * move exception message to exception constructorAaron Patterson2012-05-021-5/+11
| | | | | * save original exception * keep original backtrace
* Support cookie jar options for all cookie storesbrainopia2012-04-301-0/+7
|
* remove checks for encodings availabilitySergey Nartimov2011-12-251-1/+1
|
* Get rid of the close checks since we cannot reliably close the session anyway.José Valim2011-12-161-4/+0
|
* Split long string into multiple shorter ones Daniel Schierbeck2011-08-291-1/+4
| | | This makes the code more readable.
* removed deprecated methods, and related tests, from ActionPackJosh Kalderimis2011-05-241-7/+1
|
* Replace references to ActiveSupport::SecureRandom with just SecureRandom, ↵Jon Leighton2011-05-231-1/+1
| | | | and require 'securerandom' from the stdlib when active support is required.
* generated session ids should be encoded as UTF-8Aaron Patterson2011-04-141-1/+3
|
* Initialize sid should just skip instance variables.José Valim2010-10-041-0/+7
|
* Rely on Rack::Session stores API for more compatibility across the Ruby world.José Valim2010-10-031-231/+49
|
* no need to check for nil?Neeraj Singh2010-09-301-1/+1
|
* Remove more warnings on AP.Emilio Tagua2010-09-281-2/+2
|
* Only send secure cookies over SSL.W. Andrew Loe III2010-09-131-1/+4
|
* Revert "Avoid uneeded queries in session stores if sid is not given."José Valim2010-07-291-5/+2
| | | | | | First step to merge Rails and Rack session stores. Rack always expects to receive the SID since it may have different behavior if the SID is nil. This reverts commit e210895ba95e498b9debbf43a3e5ae588bca81f0.
* Set session options id to nil is respected and cancels lazy loading.José Valim2010-07-181-2/+2
|
* Avoid uneeded queries in session stores if sid is not given.José Valim2010-07-181-2/+5
|
* porting session.clear fix to master branch. [#5030 state:resolved]Aaron Patterson2010-07-011-0/+5
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Fixed that an ArgumentError is thrown when request.session_options[:id] is ↵Michael Lovitt2010-06-271-32/+32
| | | | | | | | read in the following scenario: when the cookie store is used, and the session contains a serialized object of an unloaded class, and no session data accesses have occurred yet. Pushed the stale_session_check responsibility out of the SessionHash and down into the session store, closer to where the deserialization actually occurs. Added some test coverage for this case and others related to deserialization of unloaded types. [#4938] Signed-off-by: José Valim <jose.valim@gmail.com>
* Do not mark the session as loaded if an error happened while doing it.José Valim2010-06-251-2/+1
|
* Calling exists? in the session store, without checking for stale sessions, ↵José Valim2010-06-251-1/+4
| | | | was causing the cookie store to panic because we need to unpack the whole session to get its key. This commit fixes this issue and also caches exists calls for performance improvements.
* Make sure that Rails doesn't resent session_id cookie over and over again if ↵Prem Sichanugrist2010-06-251-1/+3
| | | | | | | | it's already there [#2485 state:resolved] This apply to only Active Record store and Memcached store, as they both store only the session_id, which will be unchanged, in the cookie. Signed-off-by: José Valim <jose.valim@gmail.com>