Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 261 | -664/+434 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 463 | -11661/+11638 |
| | |||||
* | remove redundant curlies from hash arguments | Xavier Noria | 2016-08-06 | 100 | -563/+486 |
| | |||||
* | modernizes hash syntax in the rest of the project | Xavier Noria | 2016-08-06 | 3 | -16/+16 |
| | |||||
* | modernizes hash syntax in guides | Xavier Noria | 2016-08-06 | 5 | -11/+11 |
| | |||||
* | modernizes hash syntax in railties | Xavier Noria | 2016-08-06 | 8 | -29/+29 |
| | |||||
* | modernizes hash syntax in activesupport | Xavier Noria | 2016-08-06 | 57 | -1040/+1040 |
| | |||||
* | modernizes hash syntax in activerecord | Xavier Noria | 2016-08-06 | 202 | -2408/+2404 |
| | |||||
* | modernizes hash syntax in activemodel | Xavier Noria | 2016-08-06 | 4 | -7/+7 |
| | |||||
* | modernizes hash syntax in activejob | Xavier Noria | 2016-08-06 | 3 | -12/+12 |
| | |||||
* | modernizes hash syntax in actionview | Xavier Noria | 2016-08-06 | 68 | -1123/+1123 |
| | |||||
* | modernizes hash syntax in actionpack | Xavier Noria | 2016-08-06 | 95 | -2062/+2062 |
| | |||||
* | modernizes hash syntax in actioncable | Xavier Noria | 2016-08-06 | 1 | -2/+2 |
| | |||||
* | applies new string literal convention to the rest of the project | Xavier Noria | 2016-08-06 | 15 | -149/+149 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in the gemspecs | Xavier Noria | 2016-08-06 | 10 | -166/+166 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in Gemfile | Xavier Noria | 2016-08-06 | 1 | -61/+61 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in tools | Xavier Noria | 2016-08-06 | 3 | -19/+19 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in tasks | Xavier Noria | 2016-08-06 | 1 | -24/+24 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in guides | Xavier Noria | 2016-08-06 | 15 | -160/+160 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in ci | Xavier Noria | 2016-08-06 | 1 | -38/+38 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in railties/test | Xavier Noria | 2016-08-06 | 95 | -1595/+1595 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in railties/lib | Xavier Noria | 2016-08-06 | 105 | -628/+628 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in actioncable/test | Xavier Noria | 2016-08-06 | 29 | -260/+260 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in actioncable/lib | Xavier Noria | 2016-08-06 | 28 | -90/+90 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in actionmailer/test | Xavier Noria | 2016-08-06 | 17 | -257/+257 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in actionmailer/lib | Xavier Noria | 2016-08-06 | 15 | -47/+47 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in actionpack/test | Xavier Noria | 2016-08-06 | 145 | -6003/+6003 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in actionpack/lib | Xavier Noria | 2016-08-06 | 96 | -571/+571 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in actionview/test | Xavier Noria | 2016-08-06 | 57 | -1207/+1207 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in actionview/lib | Xavier Noria | 2016-08-06 | 55 | -271/+271 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in activejob/test | Xavier Noria | 2016-08-06 | 47 | -279/+279 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in activejob/lib | Xavier Noria | 2016-08-06 | 28 | -99/+99 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in activemodel/test | Xavier Noria | 2016-08-06 | 38 | -563/+563 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in activemodel/lib | Xavier Noria | 2016-08-06 | 28 | -77/+77 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in activerecord/test | Xavier Noria | 2016-08-06 | 280 | -5678/+5678 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in activerecord/lib | Xavier Noria | 2016-08-06 | 118 | -840/+840 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in activesupport/test | Xavier Noria | 2016-08-06 | 141 | -2632/+2632 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | applies new string literal convention in activesupport/lib | Xavier Noria | 2016-08-06 | 176 | -705/+705 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | adds a few cops and sorts | Xavier Noria | 2016-08-06 | 1 | -21/+48 |
| | |||||
* | Merge pull request #25998 from kamipo/enum_with_alias_attribute | Eileen M. Uchitelle | 2016-08-06 | 2 | -5/+22 |
|\ | | | | | Fix `enum` with `alias_attribute` | ||||
| * | Fix `enum` with `alias_attribute` | Ryuta Kamizono | 2016-07-31 | 2 | -5/+22 |
| | | | | | | | | Fixes #25892. | ||||
* | | Merge pull request #26023 from tekin/correct-acceptance-guidelines | Eileen M. Uchitelle | 2016-08-06 | 1 | -1/+1 |
|\ \ | | | | | | | Correct usage for acceptance validator in guide | ||||
| * | | Correct usage for acceptance validator in guide | Tekin Suleyman | 2016-08-02 | 1 | -1/+1 |
| | | | |||||
* | | | Merge pull request #26070 from claudiob/fix-404 | Claudio B | 2016-08-05 | 2 | -2/+2 |
|\ \ \ | | | | | | | | | [ci skip] Fix broken URL in guides | ||||
| * | | | [ci skip] Fix broken URL in guides | claudiob | 2016-08-05 | 2 | -2/+2 |
|/ / / | |||||
* | | | Merge pull request #25665 from kamipo/remove_unused_table_arg | Eileen M. Uchitelle | 2016-08-05 | 1 | -5/+5 |
|\ \ \ | | | | | | | | | Remove unused `table` arg for `UniquenessValidator#scope_relation` | ||||
| * | | | Remove unused `table` arg for `UniquenessValidator#scope_relation` | Ryuta Kamizono | 2016-07-18 | 1 | -5/+5 |
| | | | | |||||
* | | | | Merge pull request #26051 from kamipo/make_name_and_binds_to_optional_args | Eileen M. Uchitelle | 2016-08-05 | 3 | -6/+6 |
|\ \ \ \ | | | | | | | | | | | Make `name` and `binds` to optional args for `exec_{insert,update,delete}` | ||||
| * | | | | Make `name` and `binds` to optional args for `exec_{insert,update,delete}` | Ryuta Kamizono | 2016-08-04 | 3 | -6/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `insert`, `update`, `delete`, and `exec_query` have a default value against `name` and `binds`. But `exec_insert`, `exec_update`, and `exec_delete` not have. It is an inconvenience and inconsistent. | ||||
* | | | | | Fix GET JSON integration test request to use method override | eileencodes | 2016-08-05 | 3 | -1/+23 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a `GET` request is sent `as: :json` in an integration test the test should use Rack's method override to change to a post request so the paramters are included in the postdata. Otherwise it will not encode the parameters correctly for the integration test. Because integration test sets up it's own middleware, `Rack::MethodOverride` needs to be included in the integration tests as well. `headers ||= {}` was moved so that headers are never nil. They should default to a hash. Fixes #26033 [Eileen M. Uchitelle & Aaron Patterson] |