| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix Accept header overwritten issue when "xhr: true" in integration test
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In integration test when specify the "Accept" header with "xhr: true"
option, the Accept header is overridden with a default xhr Accept
header. The issue only affects HTTP header "Accept" but not CGI variable
"HTTP_ACCEPT".
For example:
get '/page', headers: { 'Accept' => 'application/json' }, xhr: true
# This is WRONG! And the response.content_type is also affected.
# It should be "application/json"
assert_equal "text/javascript, text/html, ...", request.accept
assert_equal 'text/html', response.content_type
The issue is in `ActionDispatch::Integration::RequestHelpers`. When
setting "xhr: true" the helper sets a default HTTP_ACCEPT if blank.
But the code doesn't consider supporting both HTTP header style and
CGI variable style.
For detail see this GitHub issue:
https://github.com/rails/rails/issues/25859
|
|\ \ \ \ \
| | | | | |
| | | | | | |
`ActiveRecord::PredicateBuilder#expand` to be private
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This method is not touched from outside.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
y-yagi/show_error_message_when_error_raised_in_rails_runner
show error message when error raised in rails runner
|
| | | | | | | |
|
| |_|/ / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Eagerly requiring Rake could put 100ms on to the Rails boot time. Shimmy that
down to 0 by requiring Rake when no native Rails command exists and we try to
run a Rake task. Or when printing all the Rake commands through `rails help`.
Fixes #25029
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty lines
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Revert passing arel node with splat binds for `where`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Passing arel node with splat binds for `where` was introduced at #22877
for uniqueness validator supports prepared statement. But I'd not like
to introduce the following usage:
```ruby
Foo.where(arel, *binds)
```
I'd like to revert this internal usage.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
A `value` is only used for checking `value.nil?`. It is unnecessary if
immediately return when `value.nil?`.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
.to_i is unnecessary for puma threads.
|
| | |_|/ / /
| |/| | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
|