aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorDavid Heinemeier Hansson <david@loudthinking.com>2017-07-06 15:22:40 +0200
committerDavid Heinemeier Hansson <david@loudthinking.com>2017-07-06 15:22:40 +0200
commitf3aba78ce8436fd09c5bade09092339a21880f7f (patch)
treeb139363c24810afea864fd2593b71c9bf84d7df7 /lib
parent740960bc9f8d5b519995c110cc45559f9fb1203b (diff)
downloadrails-f3aba78ce8436fd09c5bade09092339a21880f7f.tar.gz
rails-f3aba78ce8436fd09c5bade09092339a21880f7f.tar.bz2
rails-f3aba78ce8436fd09c5bade09092339a21880f7f.zip
Convert magic number to constant
Diffstat (limited to 'lib')
-rw-r--r--lib/active_storage/service/disk_service.rb6
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/active_storage/service/disk_service.rb b/lib/active_storage/service/disk_service.rb
index 6977b5b82e..dc7491310b 100644
--- a/lib/active_storage/service/disk_service.rb
+++ b/lib/active_storage/service/disk_service.rb
@@ -2,6 +2,8 @@ require "fileutils"
require "pathname"
class ActiveStorage::Service::DiskService < ActiveStorage::Service
+ CHUNK_SIZE = 65536
+
attr_reader :root
def initialize(root:)
@@ -10,7 +12,7 @@ class ActiveStorage::Service::DiskService < ActiveStorage::Service
def upload(key, io)
File.open(make_path_for(key), "wb") do |file|
- while chunk = io.read(65536)
+ while chunk = io.read(CHUNK_SIZE)
file.write(chunk)
end
end
@@ -19,7 +21,7 @@ class ActiveStorage::Service::DiskService < ActiveStorage::Service
def download(key)
if block_given?
File.open(path_for(key)) do |file|
- while data = file.read(65536)
+ while data = file.read(CHUNK_SIZE)
yield data
end
end