From f3aba78ce8436fd09c5bade09092339a21880f7f Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Thu, 6 Jul 2017 15:22:40 +0200 Subject: Convert magic number to constant --- lib/active_storage/service/disk_service.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/active_storage/service/disk_service.rb b/lib/active_storage/service/disk_service.rb index 6977b5b82e..dc7491310b 100644 --- a/lib/active_storage/service/disk_service.rb +++ b/lib/active_storage/service/disk_service.rb @@ -2,6 +2,8 @@ require "fileutils" require "pathname" class ActiveStorage::Service::DiskService < ActiveStorage::Service + CHUNK_SIZE = 65536 + attr_reader :root def initialize(root:) @@ -10,7 +12,7 @@ class ActiveStorage::Service::DiskService < ActiveStorage::Service def upload(key, io) File.open(make_path_for(key), "wb") do |file| - while chunk = io.read(65536) + while chunk = io.read(CHUNK_SIZE) file.write(chunk) end end @@ -19,7 +21,7 @@ class ActiveStorage::Service::DiskService < ActiveStorage::Service def download(key) if block_given? File.open(path_for(key)) do |file| - while data = file.read(65536) + while data = file.read(CHUNK_SIZE) yield data end end -- cgit v1.2.3