Merge pull request #43 from dixpac/small_gcs_service_refactoring

Remove unnecessary variables from gcs_service implementation

1 files changed, 2 insertions, 8 deletions

diff --git a/lib/active_storage/service/gcs_service.rb b/lib/active_storage/service/gcs_service.rb
index 0bcd29cab8..1addda6733 100644
--- a/lib/active_storage/service/gcs_service.rb
+++ b/lib/active_storage/service/gcs_service.rb
@@ -36,20 +36,14 @@ class ActiveStorage::Service::GCSService < ActiveStorage::Service
 
   def exist?(key)
     instrument :exist, key do |payload|
-      answer = file_for(key).present?
-      payload[:exist] = answer
-      answer
+      payload[:exist] = file_for(key).present?
     end
   end
 
   def url(key, expires_in:, disposition:, filename:)
     instrument :url, key do |payload|
       query = { "response-content-disposition" => "#{disposition}; filename=\"#{filename}\"" }
-      generated_url = file_for(key).signed_url(expires: expires_in, query: query)
-      
-      payload[:url] = generated_url
-      
-      generated_url
+      payload[:url] = file_for(key).signed_url(expires: expires_in, query: query)
     end
   end