diff options
| author | George Claghorn <george.claghorn@gmail.com> | 2017-07-13 14:54:30 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-07-13 14:54:30 -0400 |
| commit | 50bec56254c72a0a11815a13f3469294af8c89e5 (patch) | |
| tree | 1ba9f56e87c9b2b12bd91123638c5823514171d5 /lib/active_storage | |
| parent | c55af14d1b50c965d6c1f048ae044952de23aff2 (diff) | |
| parent | 2a738b31c538c0627a46504733fca3c914e1724e (diff) | |
| download | rails-50bec56254c72a0a11815a13f3469294af8c89e5.tar.gz rails-50bec56254c72a0a11815a13f3469294af8c89e5.tar.bz2 rails-50bec56254c72a0a11815a13f3469294af8c89e5.zip | |
Merge pull request #43 from dixpac/small_gcs_service_refactoring
Remove unnecessary variables from gcs_service implementation
Diffstat (limited to 'lib/active_storage')
| -rw-r--r-- | lib/active_storage/service/gcs_service.rb | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/lib/active_storage/service/gcs_service.rb b/lib/active_storage/service/gcs_service.rb index 0bcd29cab8..1addda6733 100644 --- a/lib/active_storage/service/gcs_service.rb +++ b/lib/active_storage/service/gcs_service.rb @@ -36,20 +36,14 @@ class ActiveStorage::Service::GCSService < ActiveStorage::Service def exist?(key) instrument :exist, key do |payload| - answer = file_for(key).present? - payload[:exist] = answer - answer + payload[:exist] = file_for(key).present? end end def url(key, expires_in:, disposition:, filename:) instrument :url, key do |payload| query = { "response-content-disposition" => "#{disposition}; filename=\"#{filename}\"" } - generated_url = file_for(key).signed_url(expires: expires_in, query: query) - - payload[:url] = generated_url - - generated_url + payload[:url] = file_for(key).signed_url(expires: expires_in, query: query) end end |