diff options
author | George Claghorn <george@basecamp.com> | 2019-05-30 22:33:29 -0400 |
---|---|---|
committer | George Claghorn <george@basecamp.com> | 2019-05-30 22:33:29 -0400 |
commit | 5ce1f66d7ac50492f4cd1e6bd0170b2c888ec73d (patch) | |
tree | 4c74e8e4deeb2ba9e8a1bbe00e9f0ed53a8cd374 /activestorage | |
parent | 165785e8cf43456816c8152ca4295640b21d1765 (diff) | |
download | rails-5ce1f66d7ac50492f4cd1e6bd0170b2c888ec73d.tar.gz rails-5ce1f66d7ac50492f4cd1e6bd0170b2c888ec73d.tar.bz2 rails-5ce1f66d7ac50492f4cd1e6bd0170b2c888ec73d.zip |
Add a changelog entry for 165785e
Diffstat (limited to 'activestorage')
-rw-r--r-- | activestorage/CHANGELOG.md | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/activestorage/CHANGELOG.md b/activestorage/CHANGELOG.md index 351d8687a4..2d9fe56858 100644 --- a/activestorage/CHANGELOG.md +++ b/activestorage/CHANGELOG.md @@ -1,6 +1,15 @@ +* Image analysis is skipped if ImageMagick returns an error. + + `ActiveStorage::Analyzer::ImageAnalyzer#metadata` would previously raise a + `MiniMagick::Error`, which caused persistent `ActiveStorage::AnalyzeJob` + failures. It now logs the error and returns `{}`, resulting in no metadata + being added to the offending image blob. + + *George Claghorn* + * Method calls on singular attachments return `nil` when no file is attached. - Previously, assuming the following User model, `user.avatar.filename` would + Previously, assuming the following User model, `user.avatar.filename` would raise a `Module::DelegationError` if no avatar was attached: ```ruby @@ -8,7 +17,7 @@ has_one_attached :avatar end ``` - + They now return `nil`. *Matthew Tanous* |