From 5ce1f66d7ac50492f4cd1e6bd0170b2c888ec73d Mon Sep 17 00:00:00 2001 From: George Claghorn Date: Thu, 30 May 2019 22:33:29 -0400 Subject: Add a changelog entry for 165785e --- activestorage/CHANGELOG.md | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) (limited to 'activestorage') diff --git a/activestorage/CHANGELOG.md b/activestorage/CHANGELOG.md index 351d8687a4..2d9fe56858 100644 --- a/activestorage/CHANGELOG.md +++ b/activestorage/CHANGELOG.md @@ -1,6 +1,15 @@ +* Image analysis is skipped if ImageMagick returns an error. + + `ActiveStorage::Analyzer::ImageAnalyzer#metadata` would previously raise a + `MiniMagick::Error`, which caused persistent `ActiveStorage::AnalyzeJob` + failures. It now logs the error and returns `{}`, resulting in no metadata + being added to the offending image blob. + + *George Claghorn* + * Method calls on singular attachments return `nil` when no file is attached. - Previously, assuming the following User model, `user.avatar.filename` would + Previously, assuming the following User model, `user.avatar.filename` would raise a `Module::DelegationError` if no avatar was attached: ```ruby @@ -8,7 +17,7 @@ has_one_attached :avatar end ``` - + They now return `nil`. *Matthew Tanous* -- cgit v1.2.3