aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2017-02-26 19:11:01 +0900
committerRyuta Kamizono <kamipo@gmail.com>2017-02-26 19:11:01 +0900
commit97d46c17ea9113b0ce970167f5208c8d9170915c (patch)
tree5b08b4709749451130f53c00ed83b5d338d16fd5 /activerecord
parent83f7f4f0aff116433b5be5fb21a3a1e8a24d8299 (diff)
downloadrails-97d46c17ea9113b0ce970167f5208c8d9170915c.tar.gz
rails-97d46c17ea9113b0ce970167f5208c8d9170915c.tar.bz2
rails-97d46c17ea9113b0ce970167f5208c8d9170915c.zip
Remove useless `select_values += select_values`
`select_values` is a local variable defined at previous line. `select_values += select_values` is totally useless.
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/lib/active_record/relation/calculations.rb1
1 files changed, 0 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
index b3168772e1..973678704f 100644
--- a/activerecord/lib/active_record/relation/calculations.rb
+++ b/activerecord/lib/active_record/relation/calculations.rb
@@ -282,7 +282,6 @@ module ActiveRecord
operation,
distinct).as(aggregate_alias)
]
- select_values += select_values unless having_clause.empty?
select_values.concat group_columns.map { |aliaz, field|
if field.respond_to?(:as)