From 97d46c17ea9113b0ce970167f5208c8d9170915c Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Sun, 26 Feb 2017 19:11:01 +0900 Subject: Remove useless `select_values += select_values` `select_values` is a local variable defined at previous line. `select_values += select_values` is totally useless. --- activerecord/lib/active_record/relation/calculations.rb | 1 - 1 file changed, 1 deletion(-) (limited to 'activerecord') diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb index b3168772e1..973678704f 100644 --- a/activerecord/lib/active_record/relation/calculations.rb +++ b/activerecord/lib/active_record/relation/calculations.rb @@ -282,7 +282,6 @@ module ActiveRecord operation, distinct).as(aggregate_alias) ] - select_values += select_values unless having_clause.empty? select_values.concat group_columns.map { |aliaz, field| if field.respond_to?(:as) -- cgit v1.2.3