aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
diff options
context:
space:
mode:
authorAndrew White <pixeltrix@users.noreply.github.com>2017-02-26 11:52:07 +0000
committerGitHub <noreply@github.com>2017-02-26 11:52:07 +0000
commit691a39b206f09c524582505da16c4ea599d79cb0 (patch)
treebd8a8d20ef0194c68eb4fc66bb28076602c82911 /activerecord
parent689971378b34db4757f1d57f011caa2515f0c238 (diff)
parent97d46c17ea9113b0ce970167f5208c8d9170915c (diff)
downloadrails-691a39b206f09c524582505da16c4ea599d79cb0.tar.gz
rails-691a39b206f09c524582505da16c4ea599d79cb0.tar.bz2
rails-691a39b206f09c524582505da16c4ea599d79cb0.zip
Merge pull request #28179 from kamipo/remove_useless_line
Remove useless `select_values += select_values`
Diffstat (limited to 'activerecord')
-rw-r--r--activerecord/lib/active_record/relation/calculations.rb1
1 files changed, 0 insertions, 1 deletions
diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
index b3168772e1..973678704f 100644
--- a/activerecord/lib/active_record/relation/calculations.rb
+++ b/activerecord/lib/active_record/relation/calculations.rb
@@ -282,7 +282,6 @@ module ActiveRecord
operation,
distinct).as(aggregate_alias)
]
- select_values += select_values unless having_clause.empty?
select_values.concat group_columns.map { |aliaz, field|
if field.respond_to?(:as)