aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/models/rating.rb
diff options
context:
space:
mode:
authorKlas Eskilson <klas.eskilson@gmail.com>2017-01-03 16:24:42 -0800
committerKlas Eskilson <klas.eskilson@gmail.com>2017-02-07 11:09:34 -0800
commit4a7b4f88cd3fc10ab56edc3f88d5db0c4f871dc9 (patch)
tree55393f0cecba8fb49b28585502d7bea653129963 /activerecord/test/models/rating.rb
parent6599e07674d2389de45b91a11d3be5eb0fbd92f3 (diff)
downloadrails-4a7b4f88cd3fc10ab56edc3f88d5db0c4f871dc9.tar.gz
rails-4a7b4f88cd3fc10ab56edc3f88d5db0c4f871dc9.tar.bz2
rails-4a7b4f88cd3fc10ab56edc3f88d5db0c4f871dc9.zip
Use `count(:all)` in HasManyAssociation#count_records
Problem: Calling `count` on an association can cause invalid SQL queries to be created where the `SELECT COUNT(a, b, c)` function receives multiple columns. This will cause a `StatementInvalid` exception later on. Solution: Use `count(:all)`, which generates a `SELECT COUNT(*)...` query independently of the association. This also includes a test case that, before the fix, broke.
Diffstat (limited to 'activerecord/test/models/rating.rb')
0 files changed, 0 insertions, 0 deletions