diff options
| author | Klas Eskilson <klas.eskilson@gmail.com> | 2017-01-03 16:24:42 -0800 |
|---|---|---|
| committer | Klas Eskilson <klas.eskilson@gmail.com> | 2017-02-07 11:09:34 -0800 |
| commit | 4a7b4f88cd3fc10ab56edc3f88d5db0c4f871dc9 (patch) | |
| tree | 55393f0cecba8fb49b28585502d7bea653129963 /activerecord/test/models | |
| parent | 6599e07674d2389de45b91a11d3be5eb0fbd92f3 (diff) | |
| download | rails-4a7b4f88cd3fc10ab56edc3f88d5db0c4f871dc9.tar.gz rails-4a7b4f88cd3fc10ab56edc3f88d5db0c4f871dc9.tar.bz2 rails-4a7b4f88cd3fc10ab56edc3f88d5db0c4f871dc9.zip | |
Use `count(:all)` in HasManyAssociation#count_records
Problem: Calling `count` on an association can cause invalid SQL queries
to be created where the `SELECT COUNT(a, b, c)` function receives
multiple columns. This will cause a `StatementInvalid` exception later
on.
Solution: Use `count(:all)`, which generates a `SELECT COUNT(*)...`
query independently of the association.
This also includes a test case that, before the fix, broke.
Diffstat (limited to 'activerecord/test/models')
| -rw-r--r-- | activerecord/test/models/company.rb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/activerecord/test/models/company.rb b/activerecord/test/models/company.rb index 20e37710e7..7ab969cdf1 100644 --- a/activerecord/test/models/company.rb +++ b/activerecord/test/models/company.rb @@ -85,6 +85,8 @@ class Firm < Company has_many :association_with_references, -> { references(:foo) }, class_name: "Client" + has_many :developers_with_select, -> { select("id, name, first_name") }, class_name: "Developer" + has_one :lead_developer, class_name: "Developer" has_many :projects |