aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord/test/cases/database_statements_test.rb
diff options
context:
space:
mode:
authorRyuta Kamizono <kamipo@gmail.com>2016-01-17 17:08:24 +0900
committerRyuta Kamizono <kamipo@gmail.com>2016-03-02 09:37:14 +0900
commit6b937bb9556bc7c51aa8cfa60791c4910763e5e3 (patch)
tree7441c82e364118ad4bee4975c093c520dd5c26e6 /activerecord/test/cases/database_statements_test.rb
parent7fa15fe694561b862773456edc11964556fb913b (diff)
downloadrails-6b937bb9556bc7c51aa8cfa60791c4910763e5e3.tar.gz
rails-6b937bb9556bc7c51aa8cfa60791c4910763e5e3.tar.bz2
rails-6b937bb9556bc7c51aa8cfa60791c4910763e5e3.zip
Deprecate `{insert|update|delete}_sql` in `DatabaseStatements`
Originally, `{insert|update|delete}_sql` is protected methods. We can use the `{insert|update|delete}` public methods instead.
Diffstat (limited to 'activerecord/test/cases/database_statements_test.rb')
-rw-r--r--activerecord/test/cases/database_statements_test.rb6
1 files changed, 6 insertions, 0 deletions
diff --git a/activerecord/test/cases/database_statements_test.rb b/activerecord/test/cases/database_statements_test.rb
index ba085991e0..3169408ac0 100644
--- a/activerecord/test/cases/database_statements_test.rb
+++ b/activerecord/test/cases/database_statements_test.rb
@@ -13,6 +13,12 @@ class DatabaseStatementsTest < ActiveRecord::TestCase
assert_not_nil return_the_inserted_id(method: :create)
end
+ def test_insert_update_delete_sql_is_deprecated
+ assert_deprecated { @connection.insert_sql("INSERT INTO accounts (firm_id,credit_limit) VALUES (42,5000)") }
+ assert_deprecated { @connection.update_sql("UPDATE accounts SET credit_limit = 6000 WHERE firm_id = 42") }
+ assert_deprecated { @connection.delete_sql("DELETE FROM accounts WHERE firm_id = 42") }
+ end
+
private
def return_the_inserted_id(method:)