From 6b937bb9556bc7c51aa8cfa60791c4910763e5e3 Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Sun, 17 Jan 2016 17:08:24 +0900 Subject: Deprecate `{insert|update|delete}_sql` in `DatabaseStatements` Originally, `{insert|update|delete}_sql` is protected methods. We can use the `{insert|update|delete}` public methods instead. --- activerecord/test/cases/database_statements_test.rb | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'activerecord/test/cases/database_statements_test.rb') diff --git a/activerecord/test/cases/database_statements_test.rb b/activerecord/test/cases/database_statements_test.rb index ba085991e0..3169408ac0 100644 --- a/activerecord/test/cases/database_statements_test.rb +++ b/activerecord/test/cases/database_statements_test.rb @@ -13,6 +13,12 @@ class DatabaseStatementsTest < ActiveRecord::TestCase assert_not_nil return_the_inserted_id(method: :create) end + def test_insert_update_delete_sql_is_deprecated + assert_deprecated { @connection.insert_sql("INSERT INTO accounts (firm_id,credit_limit) VALUES (42,5000)") } + assert_deprecated { @connection.update_sql("UPDATE accounts SET credit_limit = 6000 WHERE firm_id = 42") } + assert_deprecated { @connection.delete_sql("DELETE FROM accounts WHERE firm_id = 42") } + end + private def return_the_inserted_id(method:) -- cgit v1.2.3