aboutsummaryrefslogtreecommitdiffstats
path: root/activejob/test/integration
diff options
context:
space:
mode:
authorYves Senn <yves.senn@gmail.com>2015-08-13 09:20:39 +0200
committerYves Senn <yves.senn@gmail.com>2015-08-13 09:20:39 +0200
commit48a183ecb9992723a0b7dc8eee1c4bd41cf8d921 (patch)
tree9cf5019046a88622899a4f0cae396f0476f4f98b /activejob/test/integration
parent3b0e1e49e092d49db5f8ca590ae1e4342d16ba5f (diff)
downloadrails-48a183ecb9992723a0b7dc8eee1c4bd41cf8d921.tar.gz
rails-48a183ecb9992723a0b7dc8eee1c4bd41cf8d921.tar.bz2
rails-48a183ecb9992723a0b7dc8eee1c4bd41cf8d921.zip
use `assert_not` instead of `refute` as mentioned in our guides.
As described in the "Follow Coding Conventions" section in our contribution guide (http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) we favor `assert_not` over `refute`. While we don't usually make stylistic changes on it's own I opted to do it in this case. The reason being that test cases are usually copied as a starting point for new tests. This results in a spread of `refute` in files that have been using it already.
Diffstat (limited to 'activejob/test/integration')
-rw-r--r--activejob/test/integration/queuing_test.rb5
1 files changed, 2 insertions, 3 deletions
diff --git a/activejob/test/integration/queuing_test.rb b/activejob/test/integration/queuing_test.rb
index e1634972d1..1d1e675435 100644
--- a/activejob/test/integration/queuing_test.rb
+++ b/activejob/test/integration/queuing_test.rb
@@ -59,14 +59,13 @@ class QueuingTest < ActiveSupport::TestCase
test 'should supply a provider_job_id when available for immediate jobs' do
skip unless adapter_is?(:delayed_job, :sidekiq, :qu, :que)
test_job = TestJob.perform_later @id
- refute test_job.provider_job_id.nil?, 'Provider job id should be set by provider'
+ assert test_job.provider_job_id, 'Provider job id should be set by provider'
end
test 'should supply a provider_job_id when available for delayed jobs' do
skip unless adapter_is?(:delayed_job, :sidekiq, :que)
delayed_test_job = TestJob.set(wait: 1.minute).perform_later @id
- refute delayed_test_job.provider_job_id.nil?,
- 'Provider job id should by set for delayed jobs by provider'
+ assert delayed_test_job.provider_job_id, 'Provider job id should by set for delayed jobs by provider'
end
test 'current locale is kept while running perform_later' do