From 48a183ecb9992723a0b7dc8eee1c4bd41cf8d921 Mon Sep 17 00:00:00 2001 From: Yves Senn Date: Thu, 13 Aug 2015 09:20:39 +0200 Subject: use `assert_not` instead of `refute` as mentioned in our guides. As described in the "Follow Coding Conventions" section in our contribution guide (http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) we favor `assert_not` over `refute`. While we don't usually make stylistic changes on it's own I opted to do it in this case. The reason being that test cases are usually copied as a starting point for new tests. This results in a spread of `refute` in files that have been using it already. --- activejob/test/integration/queuing_test.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'activejob/test/integration') diff --git a/activejob/test/integration/queuing_test.rb b/activejob/test/integration/queuing_test.rb index e1634972d1..1d1e675435 100644 --- a/activejob/test/integration/queuing_test.rb +++ b/activejob/test/integration/queuing_test.rb @@ -59,14 +59,13 @@ class QueuingTest < ActiveSupport::TestCase test 'should supply a provider_job_id when available for immediate jobs' do skip unless adapter_is?(:delayed_job, :sidekiq, :qu, :que) test_job = TestJob.perform_later @id - refute test_job.provider_job_id.nil?, 'Provider job id should be set by provider' + assert test_job.provider_job_id, 'Provider job id should be set by provider' end test 'should supply a provider_job_id when available for delayed jobs' do skip unless adapter_is?(:delayed_job, :sidekiq, :que) delayed_test_job = TestJob.set(wait: 1.minute).perform_later @id - refute delayed_test_job.provider_job_id.nil?, - 'Provider job id should by set for delayed jobs by provider' + assert delayed_test_job.provider_job_id, 'Provider job id should by set for delayed jobs by provider' end test 'current locale is kept while running perform_later' do -- cgit v1.2.3