aboutsummaryrefslogtreecommitdiffstats
path: root/actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb
diff options
context:
space:
mode:
authoreileencodes <eileencodes@gmail.com>2016-11-12 09:49:28 -0500
committereileencodes <eileencodes@gmail.com>2017-02-20 15:07:33 -0500
commit84f82f0a84de0906d195b529a9f780141c43507a (patch)
treef2919614c9ce8f0adccdfd83e47d43f6484d17bc /actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb
parent1db7a5c285eeb61acc998c0c27788a61bd948d5c (diff)
downloadrails-84f82f0a84de0906d195b529a9f780141c43507a.tar.gz
rails-84f82f0a84de0906d195b529a9f780141c43507a.tar.bz2
rails-84f82f0a84de0906d195b529a9f780141c43507a.zip
Refactor config settings to use generated file
Originally I had set up system testing to have one configuration option to be set in the test environment. After thinking it over I think a generated class on app creation would be best. The reason for this is Capybara has a ton of configuration options that I'm sure some folks want to use. Thinking about how we handle screenshots, database transactions, and a whole bunch of other settings it would be better for users to be able to turn all of that on and off. When an app or scaffold is generated a `test/system_test_helper.rb` test helper will be generated as well. This will contain the class for tests to inherit from `ActionSystemTestCase` which will inherit from `ActionSystemTest::Base`. Here is where users can change the test driver, remove the screenshot helper, and add their additional Capybara configuration.
Diffstat (limited to 'actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb')
-rw-r--r--actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb8
1 files changed, 4 insertions, 4 deletions
diff --git a/actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb b/actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb
index 37336e976f..3264ddc86e 100644
--- a/actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb
+++ b/actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb
@@ -18,11 +18,11 @@ module ActionSystemTest
puts find_image
end
- private
- def supported?
- ActionSystemTest.driver.supports_screenshots? && !passed?
- end
+ def take_failed_screenshot
+ take_screenshot unless passed?
+ end
+ private
def image_path
path = "tmp/screenshots/failures_#{method_name}.png"
page.save_screenshot(Rails.root.join(path))