From 84f82f0a84de0906d195b529a9f780141c43507a Mon Sep 17 00:00:00 2001 From: eileencodes Date: Sat, 12 Nov 2016 09:49:28 -0500 Subject: Refactor config settings to use generated file Originally I had set up system testing to have one configuration option to be set in the test environment. After thinking it over I think a generated class on app creation would be best. The reason for this is Capybara has a ton of configuration options that I'm sure some folks want to use. Thinking about how we handle screenshots, database transactions, and a whole bunch of other settings it would be better for users to be able to turn all of that on and off. When an app or scaffold is generated a `test/system_test_helper.rb` test helper will be generated as well. This will contain the class for tests to inherit from `ActionSystemTestCase` which will inherit from `ActionSystemTest::Base`. Here is where users can change the test driver, remove the screenshot helper, and add their additional Capybara configuration. --- .../lib/action_system_test/test_helpers/screenshot_helper.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb') diff --git a/actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb b/actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb index 37336e976f..3264ddc86e 100644 --- a/actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb +++ b/actionsystemtest/lib/action_system_test/test_helpers/screenshot_helper.rb @@ -18,11 +18,11 @@ module ActionSystemTest puts find_image end - private - def supported? - ActionSystemTest.driver.supports_screenshots? && !passed? - end + def take_failed_screenshot + take_screenshot unless passed? + end + private def image_path path = "tmp/screenshots/failures_#{method_name}.png" page.save_screenshot(Rails.root.join(path)) -- cgit v1.2.3