diff options
| author | Jeremy Kemper <jeremykemper@gmail.com> | 2014-09-06 07:08:10 -0700 |
|---|---|---|
| committer | Jeremy Kemper <jeremykemper@gmail.com> | 2014-09-06 07:08:10 -0700 |
| commit | 8d75aa9cb335e9d012978dfdfd0bfa1bdf989fae (patch) | |
| tree | 8f3402884845ba7fe56866578a9d200c3d3d5ee2 /actionpack/CHANGELOG.md | |
| parent | 381f9931ec533dd9003f6e7224d7461b93f2fb24 (diff) | |
| parent | 2a78d6f561e98684a4988cdc616c6096cd4302d1 (diff) | |
| download | rails-8d75aa9cb335e9d012978dfdfd0bfa1bdf989fae.tar.gz rails-8d75aa9cb335e9d012978dfdfd0bfa1bdf989fae.tar.bz2 rails-8d75aa9cb335e9d012978dfdfd0bfa1bdf989fae.zip | |
Merge pull request #16822 from jeremy/deprecate-problematic-implicit-response-splatting
Deprecate implicit AD::Response splatting and Array conversion
Diffstat (limited to 'actionpack/CHANGELOG.md')
| -rw-r--r-- | actionpack/CHANGELOG.md | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md index e250450a76..de9722c392 100644 --- a/actionpack/CHANGELOG.md +++ b/actionpack/CHANGELOG.md @@ -1,3 +1,16 @@ +* Deprecate implicit Array conversion for Response objects. It was added + (using `#to_ary`) so we could conveniently use implicit splatting: + + status, headers, body = response + + But it also means `response + response` works and `[response].flatten` + cascades down to the Rack body. Nonsense behavior. Instead, rely on + explicit conversion and splatting with `#to_a`: + + status, header, body = *response + + *Jeremy Kemper* + * Don't rescue `IPAddr::InvalidAddressError`. `IPAddr::InvalidAddressError` does not exist in Ruby 1.9.3 |