aboutsummaryrefslogtreecommitdiffstats
path: root/actionpack/CHANGELOG.md
diff options
context:
space:
mode:
authorJeremy Kemper <jeremykemper@gmail.com>2014-09-05 13:33:20 -0700
committerJeremy Kemper <jeremykemper@gmail.com>2014-09-06 07:05:59 -0700
commit2a78d6f561e98684a4988cdc616c6096cd4302d1 (patch)
tree01b6b899ab50311435c762414a8afb7d30673542 /actionpack/CHANGELOG.md
parent31bfcdc77ca0d8cec9b5fe513bdc6f05814dd4f1 (diff)
downloadrails-2a78d6f561e98684a4988cdc616c6096cd4302d1.tar.gz
rails-2a78d6f561e98684a4988cdc616c6096cd4302d1.tar.bz2
rails-2a78d6f561e98684a4988cdc616c6096cd4302d1.zip
Deprecate implicit AD::Response splatting and Array conversion
Diffstat (limited to 'actionpack/CHANGELOG.md')
-rw-r--r--actionpack/CHANGELOG.md13
1 files changed, 13 insertions, 0 deletions
diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md
index e250450a76..de9722c392 100644
--- a/actionpack/CHANGELOG.md
+++ b/actionpack/CHANGELOG.md
@@ -1,3 +1,16 @@
+* Deprecate implicit Array conversion for Response objects. It was added
+ (using `#to_ary`) so we could conveniently use implicit splatting:
+
+ status, headers, body = response
+
+ But it also means `response + response` works and `[response].flatten`
+ cascades down to the Rack body. Nonsense behavior. Instead, rely on
+ explicit conversion and splatting with `#to_a`:
+
+ status, header, body = *response
+
+ *Jeremy Kemper*
+
* Don't rescue `IPAddr::InvalidAddressError`.
`IPAddr::InvalidAddressError` does not exist in Ruby 1.9.3