diff options
author | rono23 <rono23@gmail.com> | 2013-12-19 01:35:30 +0900 |
---|---|---|
committer | rono23 <rono23@gmail.com> | 2013-12-19 05:29:16 +0900 |
commit | ee738f960439e511285bc53b7207cebacda8db36 (patch) | |
tree | dc0ebecdfcb6258e0c4e2896f5407d1610018af3 | |
parent | 7b5cf7ef9dce90dc5352a0f220e65722fe44a962 (diff) | |
download | rails-ee738f960439e511285bc53b7207cebacda8db36.tar.gz rails-ee738f960439e511285bc53b7207cebacda8db36.tar.bz2 rails-ee738f960439e511285bc53b7207cebacda8db36.zip |
Fix to_param when attribute has multibyte character
-rw-r--r-- | activerecord/lib/active_record/integration.rb | 6 | ||||
-rw-r--r-- | activerecord/test/cases/integration_test.rb | 6 |
2 files changed, 10 insertions, 2 deletions
diff --git a/activerecord/lib/active_record/integration.rb b/activerecord/lib/active_record/integration.rb index 27576b1e61..31e2518540 100644 --- a/activerecord/lib/active_record/integration.rb +++ b/activerecord/lib/active_record/integration.rb @@ -98,8 +98,10 @@ module ActiveRecord super() else define_method :to_param do - if (default = super()) && (result = send(method_name).to_s).present? - "#{default}-#{result.squish.truncate(20, separator: /\s/, omission: nil).parameterize}" + if (default = super()) && + (result = send(method_name).to_s).present? && + (param = result.squish.truncate(20, separator: /\s/, omission: nil).parameterize).present? + "#{default}-#{param}" else default end diff --git a/activerecord/test/cases/integration_test.rb b/activerecord/test/cases/integration_test.rb index 07ffcef875..95b028e59e 100644 --- a/activerecord/test/cases/integration_test.rb +++ b/activerecord/test/cases/integration_test.rb @@ -46,6 +46,12 @@ class IntegrationTest < ActiveRecord::TestCase assert_equal '4-ab-ab-ab-ab-ab-ab', firm.to_param end + def test_to_param_class_method_multibyte_character + firm = Firm.find(4) + firm.name = "戦場ヶ原 ひたぎ" + assert_equal '4', firm.to_param + end + def test_to_param_class_method_uses_default_if_blank firm = Firm.find(4) firm.name = nil |