aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafael Mendonça França <rafaelmfranca@gmail.com>2013-01-31 08:37:53 -0800
committerRafael Mendonça França <rafaelmfranca@gmail.com>2013-01-31 08:37:53 -0800
commitd8005bcb892b0a41901da2cc4baf5e15706cb583 (patch)
tree00c2b9312cc9c60456720c71642530626653437a
parente6ec4ab87eb324c138da250941a28ec7ebf0f6b8 (diff)
parent78977c9c5fa6edd7eaa46cf8ff380b4e25825d5d (diff)
downloadrails-d8005bcb892b0a41901da2cc4baf5e15706cb583.tar.gz
rails-d8005bcb892b0a41901da2cc4baf5e15706cb583.tar.bz2
rails-d8005bcb892b0a41901da2cc4baf5e15706cb583.zip
Merge pull request #160 from t0m/issue_99_oracle_optimization
Small change to oracle paging code to trigger stopkey optimization
-rw-r--r--lib/arel/visitors/oracle.rb2
-rw-r--r--test/visitors/test_oracle.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/arel/visitors/oracle.rb b/lib/arel/visitors/oracle.rb
index 1441a20dbc..6a58a3cff2 100644
--- a/lib/arel/visitors/oracle.rb
+++ b/lib/arel/visitors/oracle.rb
@@ -26,7 +26,7 @@ module Arel
SELECT raw_sql_.*, rownum raw_rnum_
FROM (#{sql}) raw_sql_
)
- WHERE raw_rnum_ between #{offset.expr.to_i + 1 } and #{offset.expr.to_i + limit}
+ WHERE raw_rnum_ >= #{offset.expr.to_i + 1 } and rownum <= #{limit}
eosql
end
diff --git a/test/visitors/test_oracle.rb b/test/visitors/test_oracle.rb
index af81f2058b..42bfaadf8a 100644
--- a/test/visitors/test_oracle.rb
+++ b/test/visitors/test_oracle.rb
@@ -103,7 +103,7 @@ module Arel
SELECT raw_sql_.*, rownum raw_rnum_
FROM (SELECT) raw_sql_
)
- WHERE raw_rnum_ between 11 and 20
+ WHERE raw_rnum_ >= 11 and rownum <= 10
}
end