aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortom <tterrace@gmail.com>2013-01-08 09:30:35 -0500
committertom <tterrace@gmail.com>2013-01-08 09:30:35 -0500
commit78977c9c5fa6edd7eaa46cf8ff380b4e25825d5d (patch)
tree0f281ca8febb58ff9e17668fe0a20aab54ff6228
parent38d0a222e275d917a2c1d093b24457bafb600a00 (diff)
downloadrails-78977c9c5fa6edd7eaa46cf8ff380b4e25825d5d.tar.gz
rails-78977c9c5fa6edd7eaa46cf8ff380b4e25825d5d.tar.bz2
rails-78977c9c5fa6edd7eaa46cf8ff380b4e25825d5d.zip
Add oracle paging optimization discussed in issue 99
-rw-r--r--lib/arel/visitors/oracle.rb2
-rw-r--r--test/visitors/test_oracle.rb2
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/arel/visitors/oracle.rb b/lib/arel/visitors/oracle.rb
index 1441a20dbc..6a58a3cff2 100644
--- a/lib/arel/visitors/oracle.rb
+++ b/lib/arel/visitors/oracle.rb
@@ -26,7 +26,7 @@ module Arel
SELECT raw_sql_.*, rownum raw_rnum_
FROM (#{sql}) raw_sql_
)
- WHERE raw_rnum_ between #{offset.expr.to_i + 1 } and #{offset.expr.to_i + limit}
+ WHERE raw_rnum_ >= #{offset.expr.to_i + 1 } and rownum <= #{limit}
eosql
end
diff --git a/test/visitors/test_oracle.rb b/test/visitors/test_oracle.rb
index af81f2058b..42bfaadf8a 100644
--- a/test/visitors/test_oracle.rb
+++ b/test/visitors/test_oracle.rb
@@ -103,7 +103,7 @@ module Arel
SELECT raw_sql_.*, rownum raw_rnum_
FROM (SELECT) raw_sql_
)
- WHERE raw_rnum_ between 11 and 20
+ WHERE raw_rnum_ >= 11 and rownum <= 10
}
end