diff options
| author | David Heinemeier Hansson <david@loudthinking.com> | 2017-07-20 17:35:41 -0500 |
|---|---|---|
| committer | David Heinemeier Hansson <david@loudthinking.com> | 2017-07-20 17:35:41 -0500 |
| commit | beb60b9c3a3f1f51d10fa800b967402d79ffcf28 (patch) | |
| tree | dd447ebec72b5754b3f3d50bd8a3f3dbda4f29d6 | |
| parent | a968e3c3c75df3f209275d31eb0bd4ed6effd51e (diff) | |
| download | rails-beb60b9c3a3f1f51d10fa800b967402d79ffcf28.tar.gz rails-beb60b9c3a3f1f51d10fa800b967402d79ffcf28.tar.bz2 rails-beb60b9c3a3f1f51d10fa800b967402d79ffcf28.zip | |
True is the same as no arguments
| -rw-r--r-- | lib/active_storage/variant.rb | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/active_storage/variant.rb b/lib/active_storage/variant.rb index 658fb2f5bd..7fcd3924f4 100644 --- a/lib/active_storage/variant.rb +++ b/lib/active_storage/variant.rb @@ -64,10 +64,11 @@ class ActiveStorage::Variant MiniMagick::Image.read(io).tap { |transforming_image| variation.each do |(method, argument)| if method = allowed_transformational_method(method.to_sym) - if argument.present? - transforming_image.public_send(method, argument) - else + if argument.blank? || argument == true transforming_image.public_send(method) + else + # FIXME: Consider whitelisting allowed arguments as well? + transforming_image.public_send(method, argument) end end end |