From beb60b9c3a3f1f51d10fa800b967402d79ffcf28 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Thu, 20 Jul 2017 17:35:41 -0500 Subject: True is the same as no arguments --- lib/active_storage/variant.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/active_storage/variant.rb b/lib/active_storage/variant.rb index 658fb2f5bd..7fcd3924f4 100644 --- a/lib/active_storage/variant.rb +++ b/lib/active_storage/variant.rb @@ -64,10 +64,11 @@ class ActiveStorage::Variant MiniMagick::Image.read(io).tap { |transforming_image| variation.each do |(method, argument)| if method = allowed_transformational_method(method.to_sym) - if argument.present? - transforming_image.public_send(method, argument) - else + if argument.blank? || argument == true transforming_image.public_send(method) + else + # FIXME: Consider whitelisting allowed arguments as well? + transforming_image.public_send(method, argument) end end end -- cgit v1.2.3