| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
| | | | |
| | | | |
| | | | | |
Clicking the buttons don't work quite yet.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Instead of directly accessing the database with a custom query, we now
just use the Concert::find_concerts method to fetch the concerts that
are to be displayed.
This became much easier now that we don't rely on the extra concertlogs
table.
There's still stuff missing to be functionally equivalent to the old
code, but this should be a lot easier to get in place now.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
It does not make sense to have anonymous venues nowhere.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Also make sure we explicitly set the venue attribute in the constructor.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It's initialized to an empty array if not specified, that should be good
enough, and don't trip up iterating over it.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Create more of the concerts used by tests into the wpSetupBeforeClass
hook.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The commit changes the way we populate the database for the tests by
creating more entries up front. This reduces the amount of duplicated
code between the tests, but also introduce some challenges.
As modifications to the database done in the wpSetUpBeforeClass hook
are not cleaned up automatically by the WP_PHPUnit framework, we also
have to add a wpTearDownAfterClass hook so anything we set up in this
class does not disturb any other tests in other classes.
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
Since we're using our own database tables, these are not cleaned by the
default WP_PHPUnit setup. To ensure that we start on a clean slate when
running the tests, clean the env before the tests are run.
|
| | | |
| | | |
| | | |
| | | | |
There's no need to have a separate table (concertlogs) for these fields.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Reduce to one find_concerts function taking a filter to limit the
selection.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This must have been forgotten in the previous commit.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Now use a Concertlog object to render the correct subform instead of
messing with the db directly.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This allows us to instantiate a Concertlogs objects just as with Concert
and Venue objects. Also add a few instance methods to get the assigned
user for a given role, and get the role assigned to a given user.
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Now queries the user from the concertlogs table instead of going by
generating a form that is thrown away.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
No functional change, just trying to make sense of it.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Also add a `get_status` method to the Concertlogs class, returning the
press status for a given concert_id.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |_|/
|/| | |
|
| | | |
|
| |/
|/| |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The previous changes required the full venue data to be included in the
constructor. This patch ensures that we handle the old case, where only
the venue id was passed in.
We still should get the full concert object including the venue name and
city back.
|
| | |
|
| |
| |
| |
| |
| |
| | |
GoglogAdmin_AdminPage::get_allvenues did not get all venues, but
presented a selection control for selecting a venue. Renamed it as
get_venue_selector instead.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This makes the concert a full object containing all relevant info, while
we can still segment the data in the db.
Instead of this:
$concert = GiglogAdmin_Concert::get($concert_id);
$venue = GiglogAdmin_Venue::get($concert->venue());
echo "{$concert->name()} @ {$venue->name()} : {$concert->cdate()}"
You can now do:
$concert = GiglogAdmin_Concert::get($concert_id);
echo "{$concert->name()} @ {$concert->venue()->name()} : {$concert->cdate()}"
And yeah, renamed Concert::find_cid() to Concert::get() and changed it's
semantics somewhat. It now either returns the given concert if it
exists, or NULL if it does not. Simpler function; simpler to use.
|
| | |
|
|\| |
|
| |
| |
| |
| | |
in dropdown
|
| | |
|
| | |
|
|\ \
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This brings another tool in to help us keep the code in order - Psalm.
(I thought the name was fitting! :)
This will do fairly simple static analysis of the code, and report
problems and suggest fixes. It can help fix some issues itself, but
please double check that it does the right thing.
More info: https://psalm.dev
This merge also brings in fixes that was suggested by Paslm. Mostly this
is typa annotations for functions, but also some bugfixes discovered by
the tool.
|