| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |
|
|
|
|
|
|
|
| |
The previous changes required the full venue data to be included in the
constructor. This patch ensures that we handle the old case, where only
the venue id was passed in.
We still should get the full concert object including the venue name and
city back.
|
| | |
|
| |
|
|
|
|
| |
GoglogAdmin_AdminPage::get_allvenues did not get all venues, but
presented a selection control for selecting a venue. Renamed it as
get_venue_selector instead.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the concert a full object containing all relevant info, while
we can still segment the data in the db.
Instead of this:
$concert = GiglogAdmin_Concert::get($concert_id);
$venue = GiglogAdmin_Venue::get($concert->venue());
echo "{$concert->name()} @ {$venue->name()} : {$concert->cdate()}"
You can now do:
$concert = GiglogAdmin_Concert::get($concert_id);
echo "{$concert->name()} @ {$concert->venue()->name()} : {$concert->cdate()}"
And yeah, renamed Concert::find_cid() to Concert::get() and changed it's
semantics somewhat. It now either returns the given concert if it
exists, or NULL if it does not. Simpler function; simpler to use.
|
| | |
|
| |\ |
|
| | |
| |
| |
| | |
in dropdown
|
| | | |
|
| | | |
|
| |\ \
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This brings another tool in to help us keep the code in order - Psalm.
(I thought the name was fitting! :)
This will do fairly simple static analysis of the code, and report
problems and suggest fixes. It can help fix some issues itself, but
please double check that it does the right thing.
More info: https://psalm.dev
This merge also brings in fixes that was suggested by Paslm. Mostly this
is typa annotations for functions, but also some bugfixes discovered by
the tool.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
| |
|
|
| |
Modified returnuser function to not allow a user to assign multiple slots to themselves
|
| |
|
|
| |
CSS for edit form in giglog
|
| |
|
|
| |
Added test to create duplicate concert with varied cases in string
|
| |\
| |
| |
| | |
https://code.volse.net/wordpress/plugins/gigologadmin.git into andreaschanges
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Restructure the method a bit, drop the `c`prefix on variables, rename
the variable to hold the created concert, and use object notation to
pass the attributes to the constructor.
Also rename the method `get` to `find`, the only call site was the
`create` method. Drop the unnecessary method `check_duplicate`. Just use
`find` instead.
|
| | | |
|
| |\|
| |
| |
| | |
https://code.volse.net/wordpress/plugins/gigologadmin.git into andreaschanges
|
| | |
| |
| |
| |
| |
| |
| | |
Since running the bash script on windows was a bit troublesome, make the
`composer test` command a first class citizen. Still don't know how to
run a specific test case using the composer command, but at least it
should be easy to run the full test suite.
|
| | |\ |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
We probably need some better error handling here. There's a myriad of
reasons why this call could fail, and we might need to communicate the
failure reason somewhere.
|
| | | | |
|
| | |/
|/|
| |
| | |
before merging latest changes
|
| |/
|
|
| |
modified assign/unassing/returnuser functions to use dynamic column name instead of 4 different codes for each assignment type
|
| | |
|
| | |
|
| |
|
|
|
| |
Also moved dropping of band foreign key from concerts table into the db
version 5 changeset.
|
| |\ |
|
| | |
| |
| |
| | |
Modified so that band is no longer in use
|
| | | |
|
| | | |
|
| |\| |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
Particularly useful for running a specific test case:
For example:
./run-tests --filter Band::testCreateBandWithName
|
| |/
|
|
|
|
| |
The expected attributes did not have names corresponding with the
table columns, which meant that creating a band directly from a returned
table row did not produce the expected result.
|
| |\ |
|
| | | |
|
| | | |
|
| | |\
| | |
| | |
| | | |
https://code.volse.net/wordpress/plugins/gigologadmin.git into andreaschanges
|
| | |\ \
| | | |
| | | |
| | | | |
https://code.volse.net/wordpress/plugins/gigologadmin.git into andreaschanges
|
| | | | |
| | | |
| | | |
| | | | |
Set up a test env before running the test cases.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Sidenote: UK is not included in the country list. Did the brexit
everything?
|
| | |_|/
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This makes it easier to run the test script directly from the editor it
your editor supports composer. Otherwise run it from the command line:
composer run test
Or like before:
./run-tests
|
