remove JS from tests for reliability and dramatic speed increase.

1 files changed, 20 insertions, 18 deletions

diff --git a/spec/features/refinery/blog/posts_spec.rb b/spec/features/refinery/blog/posts_spec.rb
index a96b63a..3382398 100644
--- a/spec/features/refinery/blog/posts_spec.rb
+++ b/spec/features/refinery/blog/posts_spec.rb
@@ -41,25 +41,27 @@ module Refinery
 
     describe "list tagged posts" do
       context "when has tagged blog posts" do
-        before do
-          @tag_name = "chicago"
-          @post = FactoryGirl.create(:blog_post,
-                                          :title => "I Love my city",
-                                          :tag_list => @tag_name)
-          @tag = ::Refinery::Blog::Post.tag_counts_on(:tags).first
-        end
+        let!(:tag_name) { "chicago" }
+        let!(:post) {
+          FactoryGirl.create(:blog_post,
+            :title => "I Love my city",
+            :tag_list => tag_name
+          )
+        }
+        let!(:tag) { ::Refinery::Blog::Post.tag_counts_on(:tags).first }
+
         it "should have one tagged post" do
-          visit refinery.blog_tagged_posts_path(@tag.id, @tag_name.parameterize)
+          visit refinery.blog_tagged_posts_path(tag.id, tag_name.parameterize)
 
-          expect(page).to have_content(@tag_name)
-          expect(page).to have_content(@post.title)
+          expect(page).to have_content(tag_name)
+          expect(page).to have_content(post.title)
         end
       end
     end
 
     describe "#show" do
       context "when has no comments" do
-        let(:blog_post) { FactoryGirl.create(:blog_post) }
+        let!(:blog_post) { FactoryGirl.create(:blog_post) }
 
         it "should display the blog post" do
           visit refinery.blog_post_path(blog_post)
@@ -68,7 +70,7 @@ module Refinery
         end
       end
       context "when has approved comments" do
-        let(:approved_comment) { FactoryGirl.create(:approved_comment) }
+        let!(:approved_comment) { FactoryGirl.create(:approved_comment) }
 
         it "should display the comments" do
           visit refinery.blog_post_path(approved_comment.post)
@@ -78,7 +80,7 @@ module Refinery
         end
       end
       context "when has rejected comments" do
-        let(:rejected_comment) { FactoryGirl.create(:rejected_comment) }
+        let!(:rejected_comment) { FactoryGirl.create(:rejected_comment) }
 
         it "should not display the comments" do
           visit refinery.blog_post_path(rejected_comment.post)
@@ -87,7 +89,7 @@ module Refinery
         end
       end
       context "when has new comments" do
-        let(:blog_comment) { FactoryGirl.create(:blog_comment) }
+        let!(:blog_comment) { FactoryGirl.create(:blog_comment) }
 
         it "should not display the comments" do
           visit refinery.blog_post_path(blog_comment.post)
@@ -97,7 +99,7 @@ module Refinery
       end
 
       context "when posting comments" do
-        let(:blog_post) { FactoryGirl.create(:blog_post) }
+        let!(:blog_post) { FactoryGirl.create(:blog_post) }
         let(:name) { "pete" }
         let(:email) { "pete@mcawesome.com" }
         let(:body) { "Witty comment." }
@@ -121,8 +123,8 @@ module Refinery
       end
 
       context "post popular" do
-        let(:blog_post) { FactoryGirl.create(:blog_post) }
-        let(:blog_post2) { FactoryGirl.create(:blog_post) }
+        let!(:blog_post) { FactoryGirl.create(:blog_post) }
+        let!(:blog_post2) { FactoryGirl.create(:blog_post) }
 
         before do
           visit refinery.blog_post_path(blog_post)
@@ -151,7 +153,7 @@ module Refinery
     end
 
     describe "#show draft preview" do
-      let(:blog_post) { FactoryGirl.create(:blog_post_draft) }
+      let!(:blog_post) { FactoryGirl.create(:blog_post_draft) }
 
       context "when logged in as admin" do
         it "should display the draft notification" do