| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Some of the nodes classes are missing either one or many of the common comparison methods #hash, #eql? and #==.
This makes comparision and working with the ast sometimes painful, as equality or operations likes array differences (which uses a hash behind the scene) produces unexpected results.
A test has been added that ensures that every descendants of Node:
* have all 3 methods
* that all 3 methods were defined from the same class
* that the class defining all 3 is also a descendant of Node, to avoid the default ones that rely on identity only
|
|
|
|
|
| |
Since https://github.com/rails/rails/commit/213796f, `bind_values` is no
longer used from Active Record.
|
| |
|
|
|
|
|
|
|
|
| |
Now that the bind values are being stored on the actual AST, we need a
way to pull them off into the array that we were previously maintaining
separately. This requires a full walk of the AST. This is an expensive
operation, so I've also added a visitor for delegating to more than one
visitor in a single pass.
|
|
|
|
|
|
|
|
| |
Switching from `''.dup` to `String.new` had the side effect of changing
the encoding on Ruby 2.4 and later. Oddly, `String.new(encoding:
Encoding::UTF_8)` is significantly slower than `''.dup`. This seems like
a bug in Ruby, but not something we're going to address right now. A
test has been added to ensure this regression doesn't occur again.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm honestly not sure if replacing bind params with their concrete
values is something that belongs in Arel at all, as it's something that
will need to be coupled to the quoting mechanism of the caller, and
could just be accomplished by using `Quoted` instead.
Still, with the new structure we can provide a much simpler API around
substitution. The expectation of the quoter responding to `quote` is a
reasonably minimal API.
I originally used `DelegateClass` here, with the one line override of
`add_bind`, but realized that we have some funky code going on where the
collector returns the next collector to use (in practice `self` is
always returned, and I don't see why we'd ever want to do this).
Removing that would likely be worthwhile, but would be a larger
refactoring
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of a greater refactoring to have the `BindParam` nodes hold
onto their values. We want to generally keep the AST decoupled from what
you're actually doing with those values, but ultimately the usage of
`BindParam` is almost identical to how you'd use `Casted` or `Quoted`.
Forcing consumers of Arel's API to maintain the bind values separately
from the AST makes manipulating the AST essentially impossible, as you
would need to perform a full walk of the AST to determine whether a
given node contains bind parameters, and which value it maps to.
By storing the value on the bind parameter directly, we can collect them
in another AST pass (realistically it'll be part of the same pass that
performs SQL construction for performance reasons). This will
dramatically simplify AST manipulation for Rails or any other consumers
that work with bind params.
As part of this change I've removed the `BindVisitor`, which appears to
be dead code, and had tests break from this change.
|
|
|
|
|
|
| |
The "bind collector" does not actually collect bind params at all, it
substitutes them out of the final AST, replacing them with a quoted
value.
|
|\
| |
| | |
Support INSERT with multiple values (v2)
|
| | |
|
|\ \
| |/
|/| |
Make Visitor visit thread safe by holding dispatch method reference
|
| | |
|
|\ \
| | |
| | | |
Remove unused `engine`
|
| | |
| | |
| | |
| | |
| | |
| | | |
Follow up of 98fc25991137ee09b6800578117f8c1c322680f2.
`engine` is only used for `to_sql` and `where_sql` now.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 6d105c7f891a14316eab47dfff3bf1b94f3204e7, reversing
changes made to 437aa3a4bb8ad4f3f4eba299dbb1112852f9c7ac.
This broke Active Record when the values are sql literals
|
|/ / |
|
| | |
|
|\ \
| |/
|/| |
named functions compared to nil
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| | |
remove union mapping as :binary node when performing DepthFirst enumeration
|
| | |
|
|\ \
| | |
| | | |
Add Arel::Nodes::Casted to dot visitor
|
| |/
| |
| |
| |
| |
| |
| | |
Adds casted node to the dot visitor with outgoing edges to val and
attribute.
Fixes #419
|
|\ \
| | |
| | | |
Freeze all the strings in visitors
|
| | | |
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| | |
The aliases property of a table is never used other than for equality. However,
the aliases that have been created for a table aren't really something that
should affect whether a table is considered to be the same table or not. This
removal does not appear to have any affect within Active Record or within Arel.
|
|/
|
|
|
|
|
|
|
| |
Since BindParam has no value, treating it like a string
causes it to fallback to Object#to_s, leading to output like
`#<Arel::Nodes::BindParam:0x007fa43c866108>`.
Since angle brackets are significant in Dot labels, this causes
`Error: bad label format` when passing the graph into dot.
|
|\
| |
| | |
Fix issue #415 - Should Arel::Nodes::True.new() be 1 in sqlite3?
|
| | |
|
|\ \
| | |
| | | |
Support Oracle bind parameter value for Oracle12 visitor
|
| |/ |
|
|\ \
| | |
| | | |
PG: Add Support for GroupBy's Cube, Rollup and Grouping Set
|
| | |
| | |
| | |
| | | |
Visitor
|
|/ /
| |
| |
| |
| |
| |
| | |
it would generates `SELECT ... FETCH FIRST n ROWS ONLY FOR UPDATE`
which causes Oracle 12c database returns this error :
ORA-02014: cannot select FOR UPDATE from view with DISTINCT, GROUP BY, etc.
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Individual commit messages included below ***
* Preliminary support for bitwise operations as infix operators. Tests to follow.
* Added bitwise xor, shift left and shift right operators
* Fixed the BitwiseOr class so it uses the :| operator instead of :&
* All the methods for the bitwise operators in the Arel::Math module now wrap them up in Arel::Nodes::Grouping so the operation becomes isolated like addition and subtraction
* Preliminary set of tests for the new operators
* Updated README with examples of bitwise operations
* Added a new UnaryOperation class which is a riff on the InfixOperation class
* Added tests for UnaryOperation (inspired by InfixOperation tests)
* Added the bitwise not (~) operator as a UnaryOperation
* Added tests for the bitwise not operator
* Added documentation for the bitwise not operator
* Updated gemspec using `rake arel.gemspec`
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WhereSQL visitor always uses the generic ToSQL visitor to create
the where clause sql statement. This means that it'll miss database
specific statements, such as 'ILIKE' in PostgreSQL. Since the
`#where_sql` method is mainly used for ActiveRecord error reporting,
this discrepancy could be confusing to users.
This patch changes the WhereSQL visitor to use the its connection
visitor to generate SQL for each statement in the SelectManager's wheres
array. Then lets them be joined together with ' AND '.
|
|\
| |
| | |
Added test for verifying proper sql generated by minimum aggregate method
|
| | |
|