aboutsummaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorSean Griffin <sean@seantheprogrammer.com>2016-09-13 14:06:17 -0400
committerSean Griffin <sean@seantheprogrammer.com>2016-09-13 14:06:17 -0400
commit44d2ef9623847dea5cbf6208ae7b5168b374c720 (patch)
tree3b596034f285a3ad8f77debeab373674bd7b83d4 /test
parent4e0ce3d6a5a6db0d59661733c65dff84b25c8384 (diff)
downloadrails-44d2ef9623847dea5cbf6208ae7b5168b374c720.tar.gz
rails-44d2ef9623847dea5cbf6208ae7b5168b374c720.tar.bz2
rails-44d2ef9623847dea5cbf6208ae7b5168b374c720.zip
Don't store all aliases to a table
The aliases property of a table is never used other than for equality. However, the aliases that have been created for a table aren't really something that should affect whether a table is considered to be the same table or not. This removal does not appear to have any affect within Active Record or within Arel.
Diffstat (limited to 'test')
-rw-r--r--test/test_table.rb9
1 files changed, 1 insertions, 8 deletions
diff --git a/test/test_table.rb b/test/test_table.rb
index e8eaf901cc..168fde370d 100644
--- a/test/test_table.rb
+++ b/test/test_table.rb
@@ -110,10 +110,7 @@ module Arel
describe 'alias' do
it 'should create a node that proxies to a table' do
- @relation.aliases.must_equal []
-
node = @relation.alias
- @relation.aliases.must_equal [node]
node.name.must_equal 'users_2'
node[:id].relation.must_equal node
end
@@ -191,10 +188,8 @@ module Arel
describe 'equality' do
it 'is equal with equal ivars' do
relation1 = Table.new(:users)
- relation1.aliases = %w[a b c]
relation1.table_alias = 'zomg'
relation2 = Table.new(:users)
- relation2.aliases = %w[a b c]
relation2.table_alias = 'zomg'
array = [relation1, relation2]
assert_equal 1, array.uniq.size
@@ -202,11 +197,9 @@ module Arel
it 'is not equal with different ivars' do
relation1 = Table.new(:users)
- relation1.aliases = %w[a b c]
relation1.table_alias = 'zomg'
relation2 = Table.new(:users)
- relation2.aliases = %w[x y z]
- relation2.table_alias = 'zomg'
+ relation2.table_alias = 'zomg2'
array = [relation1, relation2]
assert_equal 2, array.uniq.size
end