| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Permanently setting $VERBOSE to nil causes unwanted side effects (warnings generated by app code are
silenced when triggered by a rake task but visible otherwise). silence_warnings {} would be safer to
use here since it resets $VERBOSE back to what it was when the block finishes.
|
| |
|
|
|
|
|
|
|
|
|
| |
* we no more have to manipulate the each caller strings by ourselves using caller_locations
* caller_locations runs slightly faster, and creates less objects than good old caller
Benchmark (loading an Engine 1000 times):
caller: 262.89 ms
caller_locations: 186.068 ms
|
| |
|
|
|
|
| |
_form view [Fixes #11573]
|
|
|
|
|
| |
assert_file already gives this functionality for free by passing
multiple contents.
|
|
|
|
|
|
|
|
| |
Showing welcome page in production can expose information, which should
not be visible on production if people don't override the default root
route.
This reverts commit b0caea29c2da9f4c8bb958019813482da297067d.
|
|\
| |
| | |
Match Dev/Prod parity for Index Page
|
| |
| |
| |
| |
| |
| |
| | |
With Rails 4 the default index page was moved from a static file `index.html` inside the `public/` folder to an internal controller/view inside of the railties gem. This was to allow use of erb in the default index page and to remove the requirement that new apps must delete a static file to make their index pages work. While this was a good change, the functionality was unexpected to developers who wish to get their apps running in production ASAP. They will create a new app `rails new my app`, start a server to verify it works, then immediately deploy the app to verify that it can start working in production. Unfortunately locally they see a page when they visit `localhost:3000` when they visit their production app they get an error page.
We initially anticipated this problem in the original pull request, but did not properly anticipate the severity or quantity of people who would like this functionality. Having a default index page serves as an excellent litmus test for a passed deploy on default apps, and it is very unexpected to have a page work locally, but not on production.
This change makes the default index page available in production if the developer has not over-written it by defining their own `root` path inside of routes.
|
| |
| |
| |
| |
| |
| |
| |
| | |
Fix an issue where Journey was failing to clear the named routes hash when the
routes were reloaded and since it doesn't overwrite existing routes then if a
route changed but wasn't renamed it kept the old definition. This was being
masked by the optimised url helpers so it only became apparent when passing an
options hash to the url helper.
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Thanks @fxn
|
| | |
| | |
| | |
| | | |
Closes rails/rails#11362
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- As default index page is no longer in public folder, rails hits the
welcome controller in railties for index action
- If the database is not created or username and password are
incorrect in database.yml, those errors are first shown before index
action succeeds
- welcome#index succeeds iff the database is created with correct
details in database.yml
- So this information about creating database is not required in the
index template
|
|\ \ \
| | | |
| | | | |
Fixed README link in API
|
| | |/
| |/|
| | |
| | | |
This should not be a link because
it's creating a link with activesupport README right now
|
|/ / |
|
| | |
|
| |
| |
| |
| | |
rake task included in test:all rake task.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As this middleware comes by default in a new
rails app
Added test to check omit for CheckPending when
Active Record is not included.
|
| |
| |
| |
| | |
Rack::Sendfile is loaded by default now
|
| |
| |
| |
| | |
reflect that
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 19ac034bdc9be175eff7cf54208ba14b43d97681.
And allows webservers to configure X-Sendfile-Type.
Closes #11440 thanks to [@MSch]
Conflicts:
railties/lib/rails/application.rb
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Actionview api generation
|
| | |
| | |
| | | |
CHANGELOG and LICENSE removed as suggested
|
|/ / |
|
| | |
|
|\ \
| | |
| | | |
#11381: Ignore config.eager_load=true for rake
|
| | |
| | |
| | |
| | | |
Closes #11381
|
|\ \ \
| |/ /
|/| | |
Remove unnecessary string interpolation
|
| | |
| | |
| | |
| | | |
Removed from controller template of scaffold generator.
|
|\ \ \
| | | |
| | | | |
Creating a class to handle preparing ARGV.
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
Before the AppGenerator is started, ARGV needs to be modified to
correctly account for some things. I'm extracting these out into their
own class.
|
|/ /
| |
| |
| |
| | |
Instead of using the global constant ARGV, we're changing to using the
instance variable because it is more testable.
|
|\ \
| | |
| | | |
Creating a class for carrying out rails commands.
|
| | |
| | |
| | |
| | |
| | |
| | | |
This class encapsulates a lot of logic that wasn't very object oriented.
Helper methods have been created to try to make things more logical and
easy to read.
|
|/ / |
|
| | |
|
|/ |
|
| |
|
| |
|
| |
|
|\
| |
| | |
Added missing CHANGELOG from PR #11279 [ci skip]
|
| | |
|
|/ |
|
|\
| |
| | |
Remove deprecated `ActiveRecord::Generators::ActiveModel#update_attribute`
|
| |
| |
| |
| | |
favor of `ActiveRecord::Generators::ActiveModel#update`
|
|/
|
|
| |
Thanks @egilburg.
|