aboutsummaryrefslogtreecommitdiffstats
path: root/railties
diff options
context:
space:
mode:
authorPiotr Sarnacki <drogus@gmail.com>2013-07-22 17:19:07 +0200
committerPiotr Sarnacki <drogus@gmail.com>2013-07-22 17:19:07 +0200
commit73bbf548687a3502cc87aaea4484943e65dce053 (patch)
tree7abb8d8664cbe00175ffa953a8a6f57750dc9820 /railties
parent782d2f6f83c39e9cfd2a8e650250a74c65458f88 (diff)
downloadrails-73bbf548687a3502cc87aaea4484943e65dce053.tar.gz
rails-73bbf548687a3502cc87aaea4484943e65dce053.tar.bz2
rails-73bbf548687a3502cc87aaea4484943e65dce053.zip
Revert "Match Dev/Prod parity for Index Page"
Showing welcome page in production can expose information, which should not be visible on production if people don't override the default root route. This reverts commit b0caea29c2da9f4c8bb958019813482da297067d.
Diffstat (limited to 'railties')
-rw-r--r--railties/lib/rails/application/finisher.rb4
-rw-r--r--railties/lib/rails/templates/rails/welcome/index.html.erb2
-rw-r--r--railties/test/application/routing_test.rb2
3 files changed, 3 insertions, 5 deletions
diff --git a/railties/lib/rails/application/finisher.rb b/railties/lib/rails/application/finisher.rb
index 1e4c6ca921..7a1bb1e25c 100644
--- a/railties/lib/rails/application/finisher.rb
+++ b/railties/lib/rails/application/finisher.rb
@@ -25,11 +25,9 @@ module Rails
get '/rails/info/properties' => "rails/info#properties"
get '/rails/info/routes' => "rails/info#routes"
get '/rails/info' => "rails/info#index"
+ get '/' => "rails/welcome#index"
end
end
- app.routes.append do
- get '/' => "rails/welcome#index"
- end
end
initializer :build_middleware_stack do
diff --git a/railties/lib/rails/templates/rails/welcome/index.html.erb b/railties/lib/rails/templates/rails/welcome/index.html.erb
index dd35835c6f..eb620caa00 100644
--- a/railties/lib/rails/templates/rails/welcome/index.html.erb
+++ b/railties/lib/rails/templates/rails/welcome/index.html.erb
@@ -227,7 +227,7 @@
<li>
<h2>Set up a root route to replace this page</h2>
- <p>You're seeing this page because you haven't set a root route yet.</p>
+ <p>You're seeing this page because you're running in development mode and you haven't set a root route yet.</p>
<p>Routes are set up in <span class="filename">config/routes.rb</span>.</p>
</li>
diff --git a/railties/test/application/routing_test.rb b/railties/test/application/routing_test.rb
index e1679315f8..8576a2b738 100644
--- a/railties/test/application/routing_test.rb
+++ b/railties/test/application/routing_test.rb
@@ -60,7 +60,7 @@ module ApplicationTests
test "rails/welcome in production" do
app("production")
get "/"
- assert_equal 200, last_response.status
+ assert_equal 404, last_response.status
end
test "rails/info/routes in production" do