| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false`
to `AS::Callbacks.halt_and_display_warning_on_return_false` base on
[this
discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580)
Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
|
| |
|
| |
|
|
|
|
|
|
|
| |
`default_middleware_stack` seems to kick off the `on_load` calls that
may mutate the middleware stack. We have to call that method before
merging middleware stacks, otherwise the middleware stacks get mutated
*after* the app middleware stack is built.
|
|
|
|
|
| |
We shouldn't merge the app middleware in to the config middleware for
engines.
|
|\
| |
| |
| |
| | |
jeremy/sprockets/move-asset-manifest-from-toplevel-to-config-subdir
Eliminate overlapping `app/assets` load path
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Move `app/assets/manifest.js` to `app/assets/config/manifest.js`.
Avoid the suggestion that you can/should deep-link `stylesheets/foo`.
* Pull in all toplevel stylesheets and JavaScripts, not just
`application.js` and `.css`. Demonstrate how to use `link_directory`
with a specified `.js`/`.css` type.
* Fix RAILS_ENV handling in assets tests.
* Shush warnings spam from third-party libs that distract from tests.
|
| | |
|
| |
| |
| |
| |
| |
| | |
Allocating a new middleware proxy in each application configuration and
then merging the app specific config with the global config when the app
is built.
|
| |
| |
| |
| |
| | |
Passing `--fail-fast` to the test runner will now abort the test run
on the first failure. The run continues on any unexpected errors.
|
|/
|
|
|
|
|
|
|
| |
Any failures or errors will be reported inline during the run by default.
Skipped tests will be reported if run in verbose mode.
Any result is output with failure messages and a rerun snippet for that test.
Rerun snippets won't be output after a run, unless `--defer-output` is passed.
|
|\
| |
| | |
check if @rake_patterns is defined
|
| |
| |
| |
| |
| |
| |
| | |
This removes the following warning.
```
railties/lib/rails/test_unit/minitest_plugin.rb:45: warning: instance variable @rake_patterns not initialize
```
|
| |
| |
| |
| |
| | |
Here `app` needed to be `get` because we're getting a route. This fixes
the typo so the test passes.
|
|/
|
|
|
|
| |
Vaguely related to #21605 where I proposed to remove index route since it was redirecting to the 'routes' action,
but this was kept so I thought it made sense to add some tests regarding this.
|
| |
|
| |
|
| |
|
|
|
|
| |
Accessing mime types via constants is deprecated.
|
| |
|
| |
|
|
|
|
|
|
|
| |
generator
This is follow up to #6643.
In #6643, the controller generator only had been fixed, in this commit to fix the scaffold generator.
|
|
|
|
|
| |
This can still be added to the middleware stack, but is really not
necessary. I'll follow up with a commit that deprecates the constant
|
| |
|
|
|
|
|
| |
When config `action_mailer.show_previews` is set, previews are displayed
regardless of local request check.
|
| |
|
|\
| |
| | |
Updated MySQL documentation link to MySQL latest version 5.7 everywhe…
|
| |
| |
| |
| |
| | |
skip]
Bumps from `5.6` to `5.7`
|
|/ |
|
| |
|
|\
| |
| | |
raise LoadError when a non-existent file or directory is specified to the test runner
|
| |
| |
| |
| |
| |
| |
| |
| | |
test runner sets file to be tested in plugin_rails_options,
but in plugin_rails_options, processing has been made to the argument of the
actual command rather than the argument of Minitest.run.
For example, if you run `./bin rake db:migrate test`, the options[:patterns], `db:migrate test` was incorrectly set.
|
| |
| |
| |
| |
| |
| |
| |
| | |
test runner
Currently, if a file or directory that does not exist was specified in the test runner,
that argument is ignored.
This commit has been modified to cause an error if there is no file or directory.
|
|/ |
|
| |
|
| |
|
| |
|
|\
| |
| | |
remove require of files under support that do not use
|
| |
| |
| |
| |
| |
| | |
I do not know why files under the support has been require.
However, under the support even rails application does not use.
In addition, since the default under the support file nor is generated, it requires I think not necessary
|
|/
|
|
| |
method_call_assertions
|
| |
|
|
|
|
|
| |
Just like the other places. We need to refactor this because the code
is almost identical to that in the action pack tests
|
|\
| |
| | |
Use the PORT environment variable for rails server
|
| | |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Cleaned up generators tests using internal assertion helper
|
| |/ |
|
|/ |
|