diff options
| author | Roque Pinel <repinel@gmail.com> | 2015-09-24 21:33:58 -0400 |
|---|---|---|
| committer | Roque Pinel <repinel@gmail.com> | 2015-10-01 13:04:20 -0400 |
| commit | e2b3ccd1aa56ae467b0fe5c7466136a4d18fa7ef (patch) | |
| tree | deed1044692fa672ae1a9f74ed4164be8cd4337e /railties | |
| parent | 7db7b287ecd616d61dd09147888d02b74d219dd1 (diff) | |
| download | rails-e2b3ccd1aa56ae467b0fe5c7466136a4d18fa7ef.tar.gz rails-e2b3ccd1aa56ae467b0fe5c7466136a4d18fa7ef.tar.bz2 rails-e2b3ccd1aa56ae467b0fe5c7466136a4d18fa7ef.zip | |
Refactor AS::Callbacks halt config and fix the documentation
Move from `AS::Callbacks::CallbackChain.halt_and_display_warning_on_return_false`
to `AS::Callbacks.halt_and_display_warning_on_return_false` base on
[this
discussion](https://github.com/rails/rails/pull/21218#discussion_r39354580)
Fix the documentation broken by 0a120a818d413c64ff9867125f0b03788fc306f8
Diffstat (limited to 'railties')
| -rw-r--r-- | railties/CHANGELOG.md | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/railties/CHANGELOG.md b/railties/CHANGELOG.md index 80ef1af7b5..3e45a09dec 100644 --- a/railties/CHANGELOG.md +++ b/railties/CHANGELOG.md @@ -296,10 +296,11 @@ Newly generated Rails apps have a new initializer called `callback_terminator.rb` which sets the value of the configuration option - `config.active_support.halt_callback_chains_on_return_false` to `false`. + `ActiveSupport.halt_callback_chains_on_return_false` to `false`. - As a result, new Rails apps do not halt callback chains when a callback - returns `false`; only when they are explicitly halted with `throw(:abort)`. + As a result, new Rails apps do not halt Active Record and Active Model + callback chains when a callback returns `false`; only when they are + explicitly halted with `throw(:abort)`. The terminator is *not* added when running `rake rails:update`, so returning `false` will still work on old apps ported to Rails 5, displaying a |