| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| | |
Rails env for empty string env vars
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
mtsmfm/fix-generator-command-for-nested-rails-engine"
This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing
changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1.
Reason: It breaks the public API
|
|\ \
| | |
| | |
| | |
| | | |
mtsmfm/fix-generator-command-for-nested-rails-engine
Fix generator command for nested (namespaced) rails engine
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If we create nested (namespaced) rails engine such like bukkits-admin,
`bin/rails g scaffold User name:string age:integer`
will create
`bukkits-admin/app/controllers/bukkits/users_controller.rb`
but it should create
`bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`.
In #6643, we changed `namespaced_path` as root path
because we supposed application_controller is always in root
but nested rails engine's application_controller will not.
|
| | | |
|
| | | |
|
| | | |
|
|/ / |
|
| |
| |
| |
| |
| |
| | |
- No need to remove bin/yarn separately for API only apps because
:skip_yarn is set to true for API only apps.
- Added a test for :skip_yarn config.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We want the actual order to be very predictable, so it's rightly defined
in code -- not with an on-the-fly tsort.
But we can do the tsort here, and then verify that it matches the
implemented ordering. This way we don't leave future readers guessing
which parts of the ordering are deliberate and which are arbitrary.
|
|\ \
| | |
| | |
| | |
| | |
| | | |
kbrock/fix_log_remote_ip_before_dispatcher_ips_settings
Allow log remote ip addres when config.action_dispatch.trusted_proxie…
|
|/ / |
|
| | |
|
| | |
|
|\ \ |
|
| |\ \ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixes #27447
[Matthew Draper & Yuuji Yaginuma]
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This quiet the following log.
```
create app/mailers/notifier_mailer.rb
invoke erb
create app/views/notifier_mailer
identical app/views/layouts/mailer.text.erb
identical app/views/layouts/mailer.html.erb
create app/views/notifier_mailer/foo.text.erb
create app/views/notifier_mailer/foo.html.erb
invoke test_unit
create test/mailers/notifier_mailer_test.rb
create test/mailers/previews/notifier_mailer_preview.rb
```
|
| | | |
| | | |
| | | |
| | | | |
Very similar to PR #25758, see more in depth reasoning there.
|
| | |/
| | |
| | |
| | |
| | |
| | | |
Gems like rspec-rails depend on `ARGV` being shifted, and `scaffold`
(for example) not being the first item in `ARGV`. This should allow
rspec-rails to be passing on Rails master.
|
| | |\
| | | |
| | | | |
Schema cache in YAML
|
| | | | |
|
| | | |
| | | |
| | | | |
Follow up to 0d20530e5edfd7d00fbc2a38ef5f87eca6ccc924
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In #22703, `log:clear` task has been changed to clear only standard environment
log files.
However, it is often to add a non-standard environment(e.g. "staging").
Therefore, I think than it is better to clear all environments log files by default.
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The `ServerCommand` inherits Thor, but currently does not use Thor
option parser.
Therefore, if leave the argument of Thor as it is, it becomes an error by
the argument checking of Thor.
To avoid it, to use the Thor option parser instead of reimplementing it.
Fixes #26964
|
| | |
| | |
| | | |
Move node_modules, package.json, and yarn.lock file to vendor
|
|\ \ \
| | | |
| | | | |
Add Yarn support in new apps using --yarn option
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
`@target_dir` variable was changed to local variable in 8e1714b.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
supercaracal/fix-force-ssl-if-session-store-disabled
Fix a force ssl redirection bug that occur when session store disabled.
|
| | | | | |
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | | |
MiniTest was renamed to Minitest.
Already renamed on https://github.com/rails/rails/pull/13366
But slipped into on https://github.com/rails/rails/pull/18413/files#diff-6bb90a693835b0e92910b796c8b0ef59R27
|
|/ / / |
|
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When making the new command insfrastructure I had missed that
`bin/rails runner some_file.rb some args` would pass the extra
args onto the file in `ARGV`.
Now fixed by allowing the command to take extra args again, and
make sure to remove the file name from `ARGV`.
|
| |
| |
| |
| |
| |
| |
| |
| | |
- This test was present in https://github.com/rails/rails/pull/27089
but not present on master, may be removed in merge commit?
- There was discussion about moving this to `application/rake_test` so
may be this happened in merge commit.
- https://github.com/rails/rails/pull/27089#discussion_r88731157
|
|\ \
| | |
| | |
| | | |
Fix incorrect output from rails routes when using singular resources …
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
#26606
Rails routes (even rake routes in previous versions) output showed incorrect routes when an application use resource :controller, implying that edit_controller_path match with controller#show.
The order of the output has changed to correct this. View #26606 for more information.
Added a test case, change unit test in rake to expect the new output.
Since the output of resource :controller is changing, the string spected of the railties/test/application/rake_test.rb test_rails_routes_with_controller_environment had to be modified.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
`rails plugin new` with `--full` and `--skip-sprockets` options generates a dummy application that throws `NoMethodError`.
```
% rails plugin new my_engine -S --full --skip-gemspec
% cd my_engine
% bin/rails test
rails aborted!
NoMethodError: undefined method `assets' for #<Rails::Application::Configuration:0x007f83aa1e6100>
```
|
| | |
|
| | |
|