aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
diff options
context:
space:
mode:
authorRafael França <rafaelmfranca@gmail.com>2016-11-25 10:55:03 +0100
committerGitHub <noreply@github.com>2016-11-25 10:55:03 +0100
commit6c873236d4384e6a89981a524867ddee4828097a (patch)
treef2696018f1e3e8527550ee346f276592d1625690 /railties/test
parentbce2e64e1022dc48577a7b6090fa79adcb559d11 (diff)
parentda1453e6bad5551dd85f9692b921e1ff770d0319 (diff)
downloadrails-6c873236d4384e6a89981a524867ddee4828097a.tar.gz
rails-6c873236d4384e6a89981a524867ddee4828097a.tar.bz2
rails-6c873236d4384e6a89981a524867ddee4828097a.zip
Merge pull request #27140 from supercaracal/fix-force-ssl-if-session-store-disabled
Fix a force ssl redirection bug that occur when session store disabled.
Diffstat (limited to 'railties/test')
-rw-r--r--railties/test/application/configuration_test.rb19
-rw-r--r--railties/test/isolation/abstract_unit.rb1
2 files changed, 19 insertions, 1 deletions
diff --git a/railties/test/application/configuration_test.rb b/railties/test/application/configuration_test.rb
index 7e3bd26212..c409f1ea79 100644
--- a/railties/test/application/configuration_test.rb
+++ b/railties/test/application/configuration_test.rb
@@ -1532,5 +1532,24 @@ module ApplicationTests
assert_equal :default, Rails.configuration.debug_exception_response_format
end
+
+ test "controller force_ssl declaration can be used even if session_store is disabled" do
+ make_basic_app do |application|
+ application.config.session_store :disabled
+ end
+
+ class ::OmgController < ActionController::Base
+ force_ssl
+
+ def index
+ render plain: "Yay! You're on Rails!"
+ end
+ end
+
+ get "/"
+
+ assert_equal 301, last_response.status
+ assert_equal "https://example.org/", last_response.location
+ end
end
end
diff --git a/railties/test/isolation/abstract_unit.rb b/railties/test/isolation/abstract_unit.rb
index aa0a06faf1..1902eac862 100644
--- a/railties/test/isolation/abstract_unit.rb
+++ b/railties/test/isolation/abstract_unit.rb
@@ -162,7 +162,6 @@ module TestHelpers
require "rails"
require "action_controller/railtie"
require "action_view/railtie"
- require "action_dispatch/middleware/flash"
@app = Class.new(Rails::Application)
@app.config.eager_load = false