aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Merge pull request #27619 from dixpac/add_missing_generator_test"yuuji.yaginuma2017-01-101-5/+0
| | | | | | | | | | This reverts commit 8cb3cdffdb70f3575518d24ea96ec891e40d21d0, reversing changes made to 3bc747bd8676dc940b531067e2861dcd4ac28efc. Reason: This test already exists in `SharedGeneratorTests`. Ref: https://github.com/rails/rails/blob/master/railties/test/generators/shared_generator_tests.rb#L109..L112 https://github.com/rails/rails/blob/master/railties/test/generators/app_generator_test.rb#L55..L56
* Test `--skip-git` generator optiondixpac2017-01-091-0/+5
|
* Don't generate HTML/ERB templates for scaffold controller with --api flagPrathamesh Sonpatki2017-01-071-0/+6
| | | | - Fixes #27591.
* Fix style guide violationsRafael Mendonça França2017-01-051-1/+0
|
* Merge pull request #27399 from sinogermany/rails-env-for-empty-string-env-varsRafael Mendonça França2017-01-031-0/+12
|\ | | | | | | Rails env for empty string env vars
| * Rails.env falls back to dev mode when env var is emptyDaniel Deng2017-01-041-0/+12
| |
* | Fix configuration test now that Metal#env was removedRafael Mendonça França2017-01-031-1/+1
| |
* | Revert "Merge pull request #27550 from ↵Rafael Mendonça França2017-01-031-20/+0
| | | | | | | | | | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine" This reverts commit 1e969bfb98b88799e2c759fce25a1d8cf00d7ce7, reversing changes made to a5041f267ded119c2d00b8786c2f2c1e3f93c8a1. Reason: It breaks the public API
* | Merge pull request #27550 from ↵Rafael França2017-01-031-0/+20
|\ \ | | | | | | | | | | | | mtsmfm/fix-generator-command-for-nested-rails-engine Fix generator command for nested (namespaced) rails engine
| * | Fix generator command for nested (namespaced) rails engineFumiaki MATSUSHIMA2017-01-031-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we create nested (namespaced) rails engine such like bukkits-admin, `bin/rails g scaffold User name:string age:integer` will create `bukkits-admin/app/controllers/bukkits/users_controller.rb` but it should create `bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`. In #6643, we changed `namespaced_path` as root path because we supposed application_controller is always in root but nested rails engine's application_controller will not.
* | | Remove test to the db:test:cloneRafael Mendonça França2017-01-031-10/+0
| | |
* | | Remove deprecated CONTROLLER environment variable for routes taskRafael Mendonça França2017-01-031-42/+25
| | |
* | | Remove deprecated config.serve_static_filesRafael Mendonça França2017-01-031-10/+0
| | |
* | | Remove deprecated `config.static_cache_control`Rafael Mendonça França2017-01-031-10/+0
|/ /
* | Remove bin/yarn if yarn is skipped, tidy up testsPrathamesh Sonpatki2017-01-011-0/+7
| | | | | | | | | | | | - No need to remove bin/yarn separately for API only apps because :skip_yarn is set to true for API only apps. - Added a test for :skip_yarn config.
* | Enforce middleware ordering with a test, instead of commentsMatthew Draper2016-12-311-3/+34
| | | | | | | | | | | | | | | | | | We want the actual order to be very predictable, so it's rightly defined in code -- not with an on-the-fly tsort. But we can do the tsort here, and then verify that it matches the implemented ordering. This way we don't leave future readers guessing which parts of the ordering are deliberate and which are arbitrary.
* | Merge pull request #27515 from ↵Matthew Draper2016-12-311-2/+2
|\ \ | | | | | | | | | | | | | | | kbrock/fix_log_remote_ip_before_dispatcher_ips_settings Allow log remote ip addres when config.action_dispatch.trusted_proxie…
| * | Allow log remote ip addres when config.action_dispatch.trusted_proxies passedLeonid Batizhevsky2016-12-301-1/+1
|/ /
* | `#tables` and `#table_exists?` and returns only tables and not viewsRafael Mendonça França2016-12-291-5/+3
| |
* | Remove deprecated support to passing a column to #quoteRafael Mendonça França2016-12-291-18/+1
| |
* | Merge branch 'master' into fix_26964Kasper Timm Hansen2016-12-2918-48/+84
|\ \
| * \ Merge branch 'master' into clear_all_environments_log_by_defaultRafael França2016-12-2932-88/+204
| |\ \
| | * | assert_equal takes expectation firstAkira Matsuda2016-12-261-1/+1
| | | |
| | * | Correct indent-accounting in controller route generationMatthew Draper2016-12-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #27447 [Matthew Draper & Yuuji Yaginuma]
| | * | "Use assert_nil if expecting nil. This will fail in minitest 6."Akira Matsuda2016-12-255-8/+8
| | | |
| | * | Privatize unneededly protected methods in Railties testsAkira Matsuda2016-12-246-6/+6
| | | |
| | * | quiet generators log in testyuuji.yaginuma2016-12-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This quiet the following log. ``` create app/mailers/notifier_mailer.rb invoke erb create app/views/notifier_mailer identical app/views/layouts/mailer.text.erb identical app/views/layouts/mailer.html.erb create app/views/notifier_mailer/foo.text.erb create app/views/notifier_mailer/foo.html.erb invoke test_unit create test/mailers/notifier_mailer_test.rb create test/mailers/previews/notifier_mailer_preview.rb ```
| | * | Limit length of secret being passedJon Moss2016-12-201-3/+3
| | | | | | | | | | | | | | | | Very similar to PR #25758, see more in depth reasoning there.
| | * | `ARGV.shift` before calling Rails generatorsJon Moss2016-12-171-0/+15
| | |/ | | | | | | | | | | | | | | | Gems like rspec-rails depend on `ARGV` being shifted, and `scaffold` (for example) not being the first item in `ARGV`. This should allow rspec-rails to be passing on Rails master.
| | * Merge pull request #27042 from kirs/yaml-schema-cacheRafael França2016-12-131-2/+2
| | |\ | | | | | | | | Schema cache in YAML
| | | * Use YAML to serialize schema cacheKir Shatrov2016-11-271-2/+2
| | | |
| | * | fix broken tests (#27308)Yuji Yaginuma2016-12-081-3/+2
| | | | | | | | | | | | Follow up to 0d20530e5edfd7d00fbc2a38ef5f87eca6ccc924
| | * | specify `skip_yarn` option in API-only Application (#27309)Yuji Yaginuma2016-12-081-1/+4
| | | |
| | * | Make Yarn the default, drop default vendor/asset directories (#27300)David Heinemeier Hansson2016-12-082-25/+11
| | | |
| * | | clear all environments log files by defaultyuuji.yaginuma2016-10-141-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In #22703, `log:clear` task has been changed to clear only standard environment log files. However, it is often to add a non-standard environment(e.g. "staging"). Therefore, I think than it is better to clear all environments log files by default.
* | | | use Thor option parser in server commands parseyuuji.yaginuma2016-12-241-36/+43
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | The `ServerCommand` inherits Thor, but currently does not use Thor option parser. Therefore, if leave the argument of Thor as it is, it becomes an error by the argument checking of Thor. To avoid it, to use the Thor option parser instead of reimplementing it. Fixes #26964
* | | Yarn: Move node_modules, package.json, and yarn.lock file to vendor (#27245)David Heinemeier Hansson2016-12-011-1/+1
| | | | | | | | | Move node_modules, package.json, and yarn.lock file to vendor
* | | Merge pull request #26836 from Liceth/npmGuillermo Iguaran2016-11-291-0/+24
|\ \ \ | | | | | | | | Add Yarn support in new apps using --yarn option
| * | | Add node_modules path to assets load paths when --yarn option is usedLiceth Ovalles2016-11-281-0/+1
| | | |
| * | | Add package.json for Yarn if --yarn option is addedLiceth Ovalles2016-11-281-0/+23
| | | |
* | | | rails-ujs is now shipped with Action ViewGuillermo Iguaran2016-11-292-3/+0
| | | |
* | | | use correct variable in BacktraceCleaner testyuuji.yaginuma2016-11-261-1/+1
| | | | | | | | | | | | | | | | `@target_dir` variable was changed to local variable in 8e1714b.
* | | | Merge pull request #27140 from ↵Rafael França2016-11-252-1/+19
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | supercaracal/fix-force-ssl-if-session-store-disabled Fix a force ssl redirection bug that occur when session store disabled.
| * | | | Remove aggressive unit test with mock. And add integration level test.Taishi Kasuga2016-11-242-1/+19
| | | | |
* | | | | [ci skip] `MiniTest` -> `Minitest`Fumiaki MATSUSHIMA2016-11-241-1/+1
| |/ / / |/| | | | | | | | | | | | | | | | | | | MiniTest was renamed to Minitest. Already renamed on https://github.com/rails/rails/pull/13366 But slipped into on https://github.com/rails/rails/pull/18413/files#diff-6bb90a693835b0e92910b796c8b0ef59R27
* | | | Don't add jQuery by default in new apps and use rails-ujs as UJS adapter insteadGuillermo Iguaran2016-11-213-14/+9
|/ / /
* | / deep symbolize keys on secrets.ymlIsaac Sloan2016-11-211-0/+14
| |/ |/|
* | Pass `rails runner` args onto file again.Kasper Timm Hansen2016-11-201-0/+8
| | | | | | | | | | | | | | | | | | When making the new command insfrastructure I had missed that `bin/rails runner some_file.rb some args` would pass the extra args onto the file in `ARGV`. Now fixed by allowing the command to take extra args again, and make sure to remove the file name from `ARGV`.
* | Add missing test for singular resource output in rake routesPrathamesh Sonpatki2016-11-191-0/+20
| | | | | | | | | | | | | | | | - This test was present in https://github.com/rails/rails/pull/27089 but not present on master, may be removed in merge commit? - There was discussion about moving this to `application/rake_test` so may be this happened in merge commit. - https://github.com/rails/rails/pull/27089#discussion_r88731157
* | Merge pull request #27089 from erickueen/erickueen_fix_26606Rafael Mendonça França2016-11-181-3/+3
|\ \ | | | | | | | | | Fix incorrect output from rails routes when using singular resources …