aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/generators
Commit message (Collapse)AuthorAgeFilesLines
...
| * Do not generate unused components contents in `app:update` taskyuuji.yaginuma2017-07-161-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | Currently, `app:update` generates all contents regardless of the component using in application. For example, even if not using Action Cable, `app:update` will generate a contents related to Action Cable. This is a little inconvenient. This PR checks the existence of the component and does not generate unnecessary contents. Can not check all options in this way. However, it will be able to prevent the generation of unnecessary files.
* | Fix test runner's outputyuuji.yaginuma2017-07-301-1/+1
|/ | | | | | | | Output changed due to specification change of `SummaryReporter#aggregated_results` in minitest 5.10.2. In my opinion, that should fix rails's test runner(proceeding with #29354). However, we still need discussion and the fix itself is minor, so I think that we can fix only the test first.
* Update default app files in app_generator_testKoichi ITO2017-07-061-2/+40
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-0232-32/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Merge pull request #29540 from kirs/rubocop-frozen-stringMatthew Draper2017-07-0232-0/+32
|\ | | | | | | Enforce frozen string in Rubocop
| * Enforce frozen string in RubocopKir Shatrov2017-07-0132-0/+32
| |
* | Merge pull request #29418 from dinahshi/scaffold_system_testsEileen M. Uchitelle2017-06-302-2/+36
|\ \ | |/ |/| Add system tests to generate scaffold
| * Add system tests to generate scaffoldDinah Shi2017-06-302-2/+36
| |
* | Add `railtie.rb` to the plugin generatorTsukuru Tanimichi2017-06-261-0/+2
| |
* | Deprecate an `capify!` method in generators and templatesyuuji.yaginuma2017-06-181-2/+5
| | | | | | | | | | | | | | | | | | The `capify` command has been removed by Capistrano 3 and became to `cap install`. Therefore, the `capify!` method has no meaning in Capistrano 3. I think that should deprecate. Ref: https://github.com/capistrano/capistrano/commit/492793916acf32ffe1604daec6fd4892c8935018
* | Use `require_relative` instead of `require` with full pathbogdanvlviv2017-06-141-3/+3
|/
* Replace therubyracer with mini_racerSam2017-05-301-1/+1
|
* Includes namespace in system test skelton when namespace is specifiedyuuji.yaginuma2017-05-281-0/+5
| | | | Fixes #29247
* Merge pull request #29176 from bogdanvlviv/define-path-with__dir__Matthew Draper2017-05-262-8/+8
|\ | | | | Define path with __dir__
| * Define path with __dir__bogdanvlviv2017-05-232-8/+8
| | | | | | | | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f
* | Remove redundant test methodAndy Atkinson2017-05-251-7/+1
|/
* Use recyclable cache keys (#29092)David Heinemeier Hansson2017-05-182-4/+3
|
* Should escape meta characters in regexpRyuta Kamizono2017-05-079-61/+61
|
* Merge pull request #28708 from y-yagi/dont_generate_system_test_filesRafael França2017-04-191-0/+11
|\ | | | | Don't generate system test files if `skip_system_test` option is specified
| * Don't generate system test files if `skip_system_test` option is specifiedyuuji.yaginuma2017-04-121-0/+11
| |
* | Add `form_with_generates_remote_forms` config.Kasper Timm Hansen2017-04-161-1/+0
|/ | | | | | | Allows users to not have remote forms by default, since there's more JS harness, e.g. bundling rails-ujs, otherwise. Also don't skip creating defaults file anymore. Sprockets isn't the only new config.
* Merge pull request #28557 from ↵Rafael França2017-03-271-0/+22
|\ | | | | | | | | y-yagi/remove_unnecessary_files_to_api_applications_when_app_task_task_executed Remove unnecessary files to API-only Applications when `app:task` task executed
| * Remove unnecessary files to API-only Applications when `app:task` task executedyuuji.yaginuma2017-03-241-0/+22
| |
* | Merge pull request #28546 from claudiob/drop-j-optionRafael Mendonça França2017-03-271-8/+0
|\ \ | | | | | | | | | Remove -j (--javascript) option from `rails new`
| * | Remove -j (--javascript) option from `rails new`claudiob2017-03-231-8/+0
| |/ | | | | | | | | | | | | | | | | | | | | | | The "-j" option was added 5 years ago (https://github.com/rails/rails/commit/d9c39c3a) when we wanted to support prototype-rails and jquery-rails. Prototype is not as popular and jQuery is not a requirement anymore. Still the "-j" option can be used to install *any* gem that ends in "-rails". This "might" open security issues and does not bring great benefits anymore. If you know which "-rails"-ending gem you want to install, you can manually add it to the Gemfile just like any other gem.
* | Merge pull request #28541 from ota42y/fix/gemfile_generator_fixEileen M. Uchitelle2017-03-271-0/+24
|\ \ | | | | | | ignore system test gems on Gemfile when execute with --skip-test option
| * | ignore system test gems on Gemfile when execute with --skip-test optionota42y2017-03-271-0/+24
| |/
* / add field ids when generating a scaffold form.Yves Senn2017-03-261-4/+4
|/ | | | | | This is a follow up to a6d065e. When using `form_with` you must supply field ids manually. Since the scaffold generator is using labels we need to make sure that they are linked up properly.
* Don't comment out config.file_watcher during Rails upgradeyuuji.yaginuma2017-03-221-14/+0
| | | | | | | This is necessary only when updating to Rails 5.0, it is not necessary for updating to 5.1. Related #24243
* Default to yielding a `form` variable.Kasper Timm Hansen2017-03-201-4/+4
| | | | More intention revealing and means `f` can go F itself 😋
* Add `app:update` task to enginesyuuji.yaginuma2017-03-201-0/+16
| | | | | | Occasionally we update the file generated by engine. Therefore, I think that there is a task for updating as well as application in the engine, it is convenient for updating.
* Merge pull request #28481 from y-yagi/fix_warningKasper Timm Hansen2017-03-201-3/+3
|\ | | | | Fix `warning: character class has duplicated range`
| * Fix `warning: character class has duplicated range`yuuji.yaginuma2017-03-201-3/+3
| | | | | | | | | | | | | | | | | | | | This fixes the following warnings: ``` railties/test/generators/encrypted_secrets_generator_test.rb:15: warning: character class has duplicated range: /[\w\d]+/ railties/test/generators/encrypted_secrets_generator_test.rb:18: warning: character class has duplicated range: /production:\n# external_api_key: [\w\d]+/ railties/test/generators/encrypted_secrets_generator_test.rb:19: warning: character class has duplicated range: /production:\n# external_api_key: [\w\d]+/ ```
* | Correctly check whether key is defined in configurationyuuji.yaginuma2017-03-191-0/+12
|/ | | | | | | | | | | | | It can not check correctly with `defined?` ```ruby irb(main):001:0> Rails.application.config.active_record => {:maintain_test_schema=>true, :belongs_to_required_by_default=>true} irb(main):002:0> defined?(Rails.application.config.active_record) => nil ``` Follow up to #28469
* Track the version-compatible config settings inside railtiesMatthew Draper2017-03-182-22/+8
| | | | | | | | | | | | | | | | Instead of forcing new applications to carry an initializer that just switches things to what their default "should" be, we can handle it internally. The initializer is then only used by upgraders: it shows what the new default would be (commented out), while their upgraded application continues to operate as it did before. Under this model, a multiply-upgraded application could accumulate several new_framework_defaults_*.rb files, for each release series it has traversed. A given release series only needs to generate the latest, though, because we don't support `rails app:upgrade` while skipping releases.
* Merge pull request #28409 from y-yagi/make_destroy_command_work_within_enginesEileen M. Uchitelle2017-03-151-0/+55
|\ | | | | Make destroy command work within engines
| * Make destroy command work within enginesyuuji.yaginuma2017-03-141-0/+55
| | | | | | | | | | Instead of calling methods of Rails.application directly, we need to use a method that is considered for the rails engine.
* | Rename test of `app:update` to more appropriate nameyuuji.yaginuma2017-03-151-7/+7
|/ | | | | `rails:update` was changed to `app:update` in 6fb31638c8b61731103d4963272755b217a2df87. Therefore, I think that it is better that the test name is also `app_update`.
* Merge pull request #28062 from ↵Rafael França2017-02-241-0/+15
|\ | | | | | | | | y-yagi/make_adding_gemfile_entry_work_even_if_specify_only_the_plugin_name Make adding gemfile entry work even if specify only the plugin name
| * Make adding gemfile entry work even if specify only the plugin nameyuuji.yaginuma2017-02-241-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | Whether the command was executed within the rails application is checked by whether or not the application's path matches `app_path`. https://github.com/rails/rails/blob/5-0-stable/railties/lib/rails/generators/rails/plugin/plugin_generator.rb#L439..L441 Therefore, if only plugin name is specified in `app_path`, addition to Gemfile is not done. However, in the rails guide an example of specifying only plugin name is given, and it is considered that there are many cases where only plugin name is specified. For that reason, made it work even if only plugin name was specified.
* | Revert "Revert "Add encrypted secrets""Kasper Timm Hansen2017-02-232-0/+43
| |
* | Revert "Add encrypted secrets" (#28127)David Heinemeier Hansson2017-02-232-43/+0
| |
* | Add encrypted secrets (#28038)Kasper Timm Hansen2017-02-232-0/+43
| |
* | Merge pull request #27572 from matthewd/prerelease-specifierMatthew Draper2017-02-231-4/+4
|\ \ | | | | | | Simplify the version specifier generated by prereleases
| * | Simplify the version specifier generated by prereleasesMatthew Draper2017-01-051-4/+4
| | | | | | | | | | | | | | | "~> 1.2.3.pre4" will automatically allow "1.2.4" -- no need for an explicit range.
* | | Revert back to the original of using package.json in the root of the project ↵David Heinemeier Hansson2017-02-212-6/+6
| | | | | | | | | | | | (#28093)
* | | Merge pull request #28055 from robertomiranda/patch-3Guillermo Iguaran2017-02-211-1/+1
|\ \ \ | | | | | | | | Use Puma 3.7
| * | | Use Puma 3.7.xRoberto Miranda2017-02-201-1/+1
| | |/ | |/| | | | | | | ref this commit seems that has not been merged into 3.7 https://github.com/puma/puma/commit/42bec4600c51ab8a1c1ee5a0e1b738a4ffd82bf2
* | | Move and rename system testseileencodes2017-02-202-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Move system tests back into Action Pack * Rename `ActionSystemTest` to `ActionDispatch::SystemTestCase` * Remove private base module and only make file for public `SystemTestCase` class, name private module `SystemTesting` * Rename `ActionSystemTestCase` to `ApplicationSystemTestCase` * Update corresponding documentation and guides * Delete old `ActionSystemTest` files
* | | Turn system testing into it's own gem and renameeileencodes2017-02-202-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renames `Rails::SystemTestCase` to `ActionSystemTest` and moves it to a gem under the Rails name. We need to name the class `ActionSystemTestCase` because the gem expects a module but tests themselves expect a class. Adds MIT-LICENSE, CHANGELOG, and README for the future.