aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/generators
diff options
context:
space:
mode:
authorclaudiob <claudiob@inventati.org>2017-03-23 08:07:04 -0700
committerclaudiob <claudiob@inventati.org>2017-03-23 08:07:04 -0700
commit42198064c35ff3b701496309f90df2abc229efbe (patch)
tree8a0ef8b298f25c7e4ffd82107f5a22c146edac38 /railties/test/generators
parent307fd7407f868095e107bd9af66b949b0ee40c20 (diff)
downloadrails-42198064c35ff3b701496309f90df2abc229efbe.tar.gz
rails-42198064c35ff3b701496309f90df2abc229efbe.tar.bz2
rails-42198064c35ff3b701496309f90df2abc229efbe.zip
Remove -j (--javascript) option from `rails new`
The "-j" option was added 5 years ago (https://github.com/rails/rails/commit/d9c39c3a) when we wanted to support prototype-rails and jquery-rails. Prototype is not as popular and jQuery is not a requirement anymore. Still the "-j" option can be used to install *any* gem that ends in "-rails". This "might" open security issues and does not bring great benefits anymore. If you know which "-rails"-ending gem you want to install, you can manually add it to the Gemfile just like any other gem.
Diffstat (limited to 'railties/test/generators')
-rw-r--r--railties/test/generators/app_generator_test.rb8
1 files changed, 0 insertions, 8 deletions
diff --git a/railties/test/generators/app_generator_test.rb b/railties/test/generators/app_generator_test.rb
index f6cdbd34fe..90aebee144 100644
--- a/railties/test/generators/app_generator_test.rb
+++ b/railties/test/generators/app_generator_test.rb
@@ -452,14 +452,6 @@ class AppGeneratorTest < Rails::Generators::TestCase
end
end
- def test_inclusion_of_javascript_libraries_if_required
- run_generator [destination_root, "-j", "jquery"]
- assert_file "app/assets/javascripts/application.js" do |contents|
- assert_match %r{^//= require jquery}, contents
- end
- assert_gem "jquery-rails"
- end
-
def test_javascript_is_skipped_if_required
run_generator [destination_root, "--skip-javascript"]