aboutsummaryrefslogtreecommitdiffstats
path: root/railties/test/application/rake/notes_test.rb
Commit message (Collapse)AuthorAgeFilesLines
* Enable `Layout/EmptyLinesAroundAccessModifier` copRyuta Kamizono2019-06-131-1/+0
| | | | | | | | | | | We sometimes say "✂️ newline after `private`" in a code review (e.g. https://github.com/rails/rails/pull/18546#discussion_r23188776, https://github.com/rails/rails/pull/34832#discussion_r244847195). Now `Layout/EmptyLinesAroundAccessModifier` cop have new enforced style `EnforcedStyle: only_before` (https://github.com/rubocop-hq/rubocop/pull/7059). That cop and enforced style will reduce the our code review cost.
* Respect config setting when output deprecation notice in rake tasksyuuji.yaginuma2018-09-041-0/+1
| | | | | | | | | The rake tasks which became deprecate now does not load the environment. Therefore, even if the application specifies the behavior of deprecating, the message is output to stderr ignoring the specification. It seems that this is not the expected behavior. We should respect the setting even in the rake tasks.
* Clarify `railties/test/application/rake/notes_test.rb`bogdanvlviv2018-07-211-59/+58
| | | | | | | | | | | | | After 1996fbe2a3e46ff5698bfa3812afb7f42cdfa899 `rails notes` isn't the same as `rake notes`. Since that, we should test `rake routes` instead of `rails notes` in `railties/test/application/rake/notes_test.rb` file. So I changed all occurrences of `rails routes` to `rake routes` in that file, and added assertions about deprecation warning of using `rake notes`. It will help to figure out that we should remove `railties/test/application/rake/notes_test.rb` entirely in favour of `railties/test/commands/notes_test.rb` that was added in 1996fbe2a3e46ff5698bfa3812afb7f42cdfa899.
* Fix deprecation message for `SOURCE_ANNOTATION_DIRECTORIES`yuuji.yaginuma2018-07-201-0/+3
| | | | Also, added a test that a deprecated message will be output.
* Move SourceAnnotationExtractor under Rails modulePrem Sichanugrist2018-03-221-1/+1
| | | | This class should be under Rails module as it belongs to Rails.
* Adding frozen_string_literal pragma to Railties.Pat Allan2017-08-141-0/+2
|
* Railties updates for frozen string literals.Pat Allan2017-08-141-1/+2
|
* Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"Matthew Draper2017-07-021-1/+0
| | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
* Enforce frozen string in RubocopKir Shatrov2017-07-011-0/+1
|
* applies remaining conventions across the projectXavier Noria2016-08-061-1/+1
|
* normalizes indentation and whitespace across the projectXavier Noria2016-08-061-17/+17
|
* applies new string literal convention in railties/testXavier Noria2016-08-061-14/+14
| | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
* Merge pull request #25652 from prathamesh-sonpatki/rm-boot-railsGuillermo Iguaran2016-07-081-1/+0
|\ | | | | Remove unused boot_rails method and it's usage
| * Remove unused boot_rails method and it's usagePrathamesh Sonpatki2016-07-041-1/+0
| | | | | | | | | | - The `boot_rails` method from abstract_unit.rb is empty after 2abcdfd978fdcd491576a237e8c6b. - So let's remove it and its usage.
* | Fix test to try `spec/` directory as opposed to `app/spec` which I hadJohn Meehan2016-07-051-2/+2
| | | | | | | | | | | | accidently set it to. Made the change and test still passes.
* | removed extra blank lineJohn Meehan2016-07-051-1/+0
| |
* | Allow rake notes to work with other directories.John Meehan2016-07-051-0/+13
|/ | | | | | | Additional directories can be added using SourceAnnotationExtractor::Annotation.register_directories("spec", "other_dir") Result: rake notes will now extract notes from these directories.
* Be consistent in testing outputs from railties test and use /bin/rails ↵Vipul A M2016-01-241-3/+3
| | | | | | everywhere(the default behaviour now) instead of mix of /bin/rake /bin/rails everywhere [Ryo Hashimoto & Vipul A M]
* Fix rake/notes_testschneems2015-07-291-0/+1
| | | | | | | | | | | Presumably due to https://github.com/rails/sprockets-rails/pull/265 sprockets was trying to load the "scss" gem but it isn't in the gemfile: ``` ApplicationTests::RakeTests::RakeNotesTest#test_register_a_new_extension: LoadError: cannot load such file -- sass ``` If we use an empty precompile list, it won't try to load sass.
* tests, railties tests should use `bin/` executables when possible.Yves Senn2015-06-301-3/+3
| | | | | We recommend using the `bin/` executables in our docs and guides. Let's make sure that our tests execute the same code path.
* Refactor assertion of line numbers matching 4 spacesCarlos Antonio da Silva2014-03-191-16/+4
|
* Move booting/loading tasks setup to the rake notes helper methodCarlos Antonio da Silva2014-03-191-15/+3
|
* Extract rake notes command and lines scan boilerplateCarlos Antonio da Silva2014-03-191-19/+14
| | | | Refactor to a reusable method.
* Remove extra space assertionCarlos Antonio da Silva2014-03-191-3/+2
| | | | | No need to check that each line contains an extra space, just matching the space in the regexp is enough to ensure that.
* Extract common setup for loading tasks in rake notes testsCarlos Antonio da Silva2014-03-191-29/+14
|
* Rake notes should picked up new Extensions registered in the ↵robertomiranda2014-03-171-3/+19
| | | | config/application.rb file
* Fix Shadowing extensions variable in Register Annotation Exentsionsrobertomiranda2014-03-161-5/+5
|
* Supporting .ruby, .yml and .yaml Extension in Rake Notesrobertomiranda2014-03-141-1/+6
|
* Remove .scss, .sass, .less, .haml, .slim, coffee from Rake Notes. Now we ↵robertomiranda2014-03-141-13/+3
| | | | have an API for register it in the corresponding gems
* Add Public Api for register new extensions for Rake Notesrobertomiranda2014-03-141-0/+5
|
* added test cases to find notes in a file with .builder extensionKuldeep Aggarwal2013-11-171-1/+3
|
* fix build error caused by #11900.Yves Senn2013-08-151-1/+1
|
* Adding LESS to rake notesJosh Crowder2013-08-151-0/+2
|
* handle notes in *.sass filesYuri Artemev2013-07-081-1/+3
|
* allow :dirs option for .enumerateBrian D. Burns2013-01-151-0/+39
| | | | | | Allows custom rake tasks to be defined using: SourceAnnotationExtractor.enumerate 'TODO|FIXME', dirs: %w(app lib), tag: true
* Introduce ./bin for your app's executables: bin/bundle, bin/rails, bin/rake. ↵Jeremy Kemper2013-01-061-6/+2
| | | | Executable scripts are versioned code like the rest of your app. To generate a stub for a bundled gem: 'bundle binstubs unicorn' and 'git add bin/unicorn'
* Fix failing tests related to rake notesCarlos Antonio da Silva2012-12-031-2/+2
| | | | Related to changes introduced in 553b563749517114323b4e8742509227e0daab67
* Add db to the list of default annotation foldersAntonio Cangiano2012-12-011-0/+4
|
* Add .rake to `rake notes` and `rake notes:custom`Brent J. Nordquist2012-10-121-1/+3
|
* run the notes tests in isolationAaron Patterson2012-06-191-0/+4
|
* Warnings removed for "assert_match /".Arun Agrawal2012-05-301-20/+20
|
* Remove empty lines.Jason Noble2012-04-301-4/+0
|
* Fixed styling issues brought up by @jeremyJason Noble2012-04-301-2/+1
|
* Add ability to specify custom annotation directoriesJason Noble & Ralph Shnelvar2012-04-301-0/+42
| | | | | | | | | SOURCE_ANNOTATION_DIRECTORIES='dir1,dir2' bundle exec rake notes Searches app, config, lib, script, test (default) Also searches dir1, dir2 References: #4536, #4540
* Add test coverage for rake notesJason Noble & Ralph Shnelvar2012-04-301-1/+36
| | | | | Add separate tests to verify directories covered Add tests to verify file_types
* `rake notes` and `rake notes:custom` now supportTeng Siong Ong2012-04-221-1/+7
| | | css, scss and css.
* Fixed missing space bug introduces in ↵Anton Lindqvist2012-03-221-3/+4
| | | | rails/rails@9299bfdcd387253d83b645c205b8df477f2d0940.
* Use one system call whenever possible, group rake and Dir.chdir callsCarlos Antonio da Silva2012-03-081-2/+1
|
* Display annotations from .coffee files in `rake notes`Bartlomiej Kozal2012-02-051-10/+12
|
* convert railties to use AS::TestCaseAaron Patterson2012-01-051-1/+1
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 16:08:03 +0000