Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Respect config setting when output deprecation notice in rake tasks | yuuji.yaginuma | 2018-09-04 | 1 | -0/+1 |
| | | | | | | | | | The rake tasks which became deprecate now does not load the environment. Therefore, even if the application specifies the behavior of deprecating, the message is output to stderr ignoring the specification. It seems that this is not the expected behavior. We should respect the setting even in the rake tasks. | ||||
* | Clarify `railties/test/application/rake/notes_test.rb` | bogdanvlviv | 2018-07-21 | 1 | -59/+58 |
| | | | | | | | | | | | | | After 1996fbe2a3e46ff5698bfa3812afb7f42cdfa899 `rails notes` isn't the same as `rake notes`. Since that, we should test `rake routes` instead of `rails notes` in `railties/test/application/rake/notes_test.rb` file. So I changed all occurrences of `rails routes` to `rake routes` in that file, and added assertions about deprecation warning of using `rake notes`. It will help to figure out that we should remove `railties/test/application/rake/notes_test.rb` entirely in favour of `railties/test/commands/notes_test.rb` that was added in 1996fbe2a3e46ff5698bfa3812afb7f42cdfa899. | ||||
* | Fix deprecation message for `SOURCE_ANNOTATION_DIRECTORIES` | yuuji.yaginuma | 2018-07-20 | 1 | -0/+3 |
| | | | | Also, added a test that a deprecated message will be output. | ||||
* | Move SourceAnnotationExtractor under Rails module | Prem Sichanugrist | 2018-03-22 | 1 | -1/+1 |
| | | | | This class should be under Rails module as it belongs to Rails. | ||||
* | Adding frozen_string_literal pragma to Railties. | Pat Allan | 2017-08-14 | 1 | -0/+2 |
| | |||||
* | Railties updates for frozen string literals. | Pat Allan | 2017-08-14 | 1 | -1/+2 |
| | |||||
* | Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" | Matthew Draper | 2017-07-02 | 1 | -1/+0 |
| | | | | | This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa. | ||||
* | Enforce frozen string in Rubocop | Kir Shatrov | 2017-07-01 | 1 | -0/+1 |
| | |||||
* | applies remaining conventions across the project | Xavier Noria | 2016-08-06 | 1 | -1/+1 |
| | |||||
* | normalizes indentation and whitespace across the project | Xavier Noria | 2016-08-06 | 1 | -17/+17 |
| | |||||
* | applies new string literal convention in railties/test | Xavier Noria | 2016-08-06 | 1 | -14/+14 |
| | | | | | The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default. | ||||
* | Merge pull request #25652 from prathamesh-sonpatki/rm-boot-rails | Guillermo Iguaran | 2016-07-08 | 1 | -1/+0 |
|\ | | | | | Remove unused boot_rails method and it's usage | ||||
| * | Remove unused boot_rails method and it's usage | Prathamesh Sonpatki | 2016-07-04 | 1 | -1/+0 |
| | | | | | | | | | | - The `boot_rails` method from abstract_unit.rb is empty after 2abcdfd978fdcd491576a237e8c6b. - So let's remove it and its usage. | ||||
* | | Fix test to try `spec/` directory as opposed to `app/spec` which I had | John Meehan | 2016-07-05 | 1 | -2/+2 |
| | | | | | | | | | | | | accidently set it to. Made the change and test still passes. | ||||
* | | removed extra blank line | John Meehan | 2016-07-05 | 1 | -1/+0 |
| | | |||||
* | | Allow rake notes to work with other directories. | John Meehan | 2016-07-05 | 1 | -0/+13 |
|/ | | | | | | | Additional directories can be added using SourceAnnotationExtractor::Annotation.register_directories("spec", "other_dir") Result: rake notes will now extract notes from these directories. | ||||
* | Be consistent in testing outputs from railties test and use /bin/rails ↵ | Vipul A M | 2016-01-24 | 1 | -3/+3 |
| | | | | | | everywhere(the default behaviour now) instead of mix of /bin/rake /bin/rails everywhere [Ryo Hashimoto & Vipul A M] | ||||
* | Fix rake/notes_test | schneems | 2015-07-29 | 1 | -0/+1 |
| | | | | | | | | | | | Presumably due to https://github.com/rails/sprockets-rails/pull/265 sprockets was trying to load the "scss" gem but it isn't in the gemfile: ``` ApplicationTests::RakeTests::RakeNotesTest#test_register_a_new_extension: LoadError: cannot load such file -- sass ``` If we use an empty precompile list, it won't try to load sass. | ||||
* | tests, railties tests should use `bin/` executables when possible. | Yves Senn | 2015-06-30 | 1 | -3/+3 |
| | | | | | We recommend using the `bin/` executables in our docs and guides. Let's make sure that our tests execute the same code path. | ||||
* | Refactor assertion of line numbers matching 4 spaces | Carlos Antonio da Silva | 2014-03-19 | 1 | -16/+4 |
| | |||||
* | Move booting/loading tasks setup to the rake notes helper method | Carlos Antonio da Silva | 2014-03-19 | 1 | -15/+3 |
| | |||||
* | Extract rake notes command and lines scan boilerplate | Carlos Antonio da Silva | 2014-03-19 | 1 | -19/+14 |
| | | | | Refactor to a reusable method. | ||||
* | Remove extra space assertion | Carlos Antonio da Silva | 2014-03-19 | 1 | -3/+2 |
| | | | | | No need to check that each line contains an extra space, just matching the space in the regexp is enough to ensure that. | ||||
* | Extract common setup for loading tasks in rake notes tests | Carlos Antonio da Silva | 2014-03-19 | 1 | -29/+14 |
| | |||||
* | Rake notes should picked up new Extensions registered in the ↵ | robertomiranda | 2014-03-17 | 1 | -3/+19 |
| | | | | config/application.rb file | ||||
* | Fix Shadowing extensions variable in Register Annotation Exentsions | robertomiranda | 2014-03-16 | 1 | -5/+5 |
| | |||||
* | Supporting .ruby, .yml and .yaml Extension in Rake Notes | robertomiranda | 2014-03-14 | 1 | -1/+6 |
| | |||||
* | Remove .scss, .sass, .less, .haml, .slim, coffee from Rake Notes. Now we ↵ | robertomiranda | 2014-03-14 | 1 | -13/+3 |
| | | | | have an API for register it in the corresponding gems | ||||
* | Add Public Api for register new extensions for Rake Notes | robertomiranda | 2014-03-14 | 1 | -0/+5 |
| | |||||
* | added test cases to find notes in a file with .builder extension | Kuldeep Aggarwal | 2013-11-17 | 1 | -1/+3 |
| | |||||
* | fix build error caused by #11900. | Yves Senn | 2013-08-15 | 1 | -1/+1 |
| | |||||
* | Adding LESS to rake notes | Josh Crowder | 2013-08-15 | 1 | -0/+2 |
| | |||||
* | handle notes in *.sass files | Yuri Artemev | 2013-07-08 | 1 | -1/+3 |
| | |||||
* | allow :dirs option for .enumerate | Brian D. Burns | 2013-01-15 | 1 | -0/+39 |
| | | | | | | Allows custom rake tasks to be defined using: SourceAnnotationExtractor.enumerate 'TODO|FIXME', dirs: %w(app lib), tag: true | ||||
* | Introduce ./bin for your app's executables: bin/bundle, bin/rails, bin/rake. ↵ | Jeremy Kemper | 2013-01-06 | 1 | -6/+2 |
| | | | | Executable scripts are versioned code like the rest of your app. To generate a stub for a bundled gem: 'bundle binstubs unicorn' and 'git add bin/unicorn' | ||||
* | Fix failing tests related to rake notes | Carlos Antonio da Silva | 2012-12-03 | 1 | -2/+2 |
| | | | | Related to changes introduced in 553b563749517114323b4e8742509227e0daab67 | ||||
* | Add db to the list of default annotation folders | Antonio Cangiano | 2012-12-01 | 1 | -0/+4 |
| | |||||
* | Add .rake to `rake notes` and `rake notes:custom` | Brent J. Nordquist | 2012-10-12 | 1 | -1/+3 |
| | |||||
* | run the notes tests in isolation | Aaron Patterson | 2012-06-19 | 1 | -0/+4 |
| | |||||
* | Warnings removed for "assert_match /". | Arun Agrawal | 2012-05-30 | 1 | -20/+20 |
| | |||||
* | Remove empty lines. | Jason Noble | 2012-04-30 | 1 | -4/+0 |
| | |||||
* | Fixed styling issues brought up by @jeremy | Jason Noble | 2012-04-30 | 1 | -2/+1 |
| | |||||
* | Add ability to specify custom annotation directories | Jason Noble & Ralph Shnelvar | 2012-04-30 | 1 | -0/+42 |
| | | | | | | | | | SOURCE_ANNOTATION_DIRECTORIES='dir1,dir2' bundle exec rake notes Searches app, config, lib, script, test (default) Also searches dir1, dir2 References: #4536, #4540 | ||||
* | Add test coverage for rake notes | Jason Noble & Ralph Shnelvar | 2012-04-30 | 1 | -1/+36 |
| | | | | | Add separate tests to verify directories covered Add tests to verify file_types | ||||
* | `rake notes` and `rake notes:custom` now support | Teng Siong Ong | 2012-04-22 | 1 | -1/+7 |
| | | | css, scss and css. | ||||
* | Fixed missing space bug introduces in ↵ | Anton Lindqvist | 2012-03-22 | 1 | -3/+4 |
| | | | | rails/rails@9299bfdcd387253d83b645c205b8df477f2d0940. | ||||
* | Use one system call whenever possible, group rake and Dir.chdir calls | Carlos Antonio da Silva | 2012-03-08 | 1 | -2/+1 |
| | |||||
* | Display annotations from .coffee files in `rake notes` | Bartlomiej Kozal | 2012-02-05 | 1 | -10/+12 |
| | |||||
* | convert railties to use AS::TestCase | Aaron Patterson | 2012-01-05 | 1 | -1/+1 |
| | |||||
* | Align rake notes. | Anton Lindqvist | 2011-12-26 | 1 | -0/+9 |
| |